New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't enable player controls if they where disabled when ModalDialog closes. #4690

Merged
merged 1 commit into from Oct 30, 2017

Conversation

Projects
None yet
3 participants
@nicolaslevy
Contributor

nicolaslevy commented Oct 25, 2017

Description

Don't enable player controls if they where disabled when ModalDialog closes.

Specific Changes proposed

Save the result of "player.controls()" when the ModalDialgo opens and set it again on close.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Reviewed by Two Core Contributors
@gkatsev

Sounds reasonable to me.

@gkatsev gkatsev added the patch label Oct 25, 2017

@gkatsev gkatsev added the confirmed label Oct 25, 2017

@gkatsev gkatsev merged commit afea980 into videojs:master Oct 30, 2017

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Oct 30, 2017

Member

Thanks @nicolaslevy! Expect a release in the next couple of days.

Member

gkatsev commented Oct 30, 2017

Thanks @nicolaslevy! Expect a release in the next couple of days.

gkatsev added a commit that referenced this pull request Oct 31, 2017

test: fix modal dialog test for showing controls
Also, add a test that verifies the behavior for the PR (#4690).

Fixes #4706.

gkatsev added a commit that referenced this pull request Oct 31, 2017

test: fix modal dialog test for showing controls (#4707)
Also, add a test that verifies the behavior for the PR (#4690).

Fixes #4706.
@nicolaslevy

This comment has been minimized.

Show comment
Hide comment
@nicolaslevy

nicolaslevy Oct 31, 2017

Contributor

Thanks to you @gkatsev 😄!!!
❤️ video.js!

Contributor

nicolaslevy commented Oct 31, 2017

Thanks to you @gkatsev 😄!!!
❤️ video.js!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment