New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor component.ready() #4693

Merged
merged 1 commit into from Oct 31, 2017

Conversation

Projects
None yet
3 participants
@kocoten1992
Contributor

kocoten1992 commented Oct 26, 2017

Requirements Checklist

  • refactor component.ready()
}
if (sync) {
fn.call(this);

This comment has been minimized.

@BrandonOCasey

BrandonOCasey Oct 26, 2017

Contributor

You could return after this and get rid of the else here, I think that it would fit better with the new flow of this function.

@BrandonOCasey

BrandonOCasey Oct 26, 2017

Contributor

You could return after this and get rid of the else here, I think that it would fit better with the new flow of this function.

This comment has been minimized.

@kocoten1992

kocoten1992 Oct 26, 2017

Contributor

Uhm no, the point was to easy read/debug, abusing that in only 4 line of code would make thing harder

But feel free to edit anyway

@kocoten1992

kocoten1992 Oct 26, 2017

Contributor

Uhm no, the point was to easy read/debug, abusing that in only 4 line of code would make thing harder

But feel free to edit anyway

@gkatsev

LGTM.
I could go either way wrt that particular if statement.

@gkatsev gkatsev added the confirmed label Oct 30, 2017

@gkatsev gkatsev merged commit b40858b into videojs:master Oct 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment