New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default cached src to empty string #4711

Merged
merged 1 commit into from Nov 1, 2017

Conversation

Projects
None yet
3 participants
@forbesjo
Contributor

forbesjo commented Nov 1, 2017

Description

player.src() returns undefined for a new player.

Specific Changes proposed

Default to '' if there is no source cached.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
  • Reviewed by Two Core Contributors

@forbesjo forbesjo changed the title from Default cached src to empty string to fix: default cached src to empty string Nov 1, 2017

@gkatsev

gkatsev approved these changes Nov 1, 2017

@BrandonOCasey

makes sense, it is the default in most browsers from what I have seen.

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Nov 1, 2017

Member

@BrandonOCasey yup, plus, we already do that for currentSrc().

Member

gkatsev commented Nov 1, 2017

@BrandonOCasey yup, plus, we already do that for currentSrc().

@gkatsev gkatsev merged commit 9acbcd8 into videojs:master Nov 1, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment