New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a version function to all advanced plugin instances #4714

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
3 participants
@BrandonOCasey
Contributor

BrandonOCasey commented Nov 2, 2017

Description

Having to use videojs.getPluginVersion(.constructor.name) is a bit weird when you already have an instance. I would even say we should get rid of the getPluginVersion function or deprecate it.

Requirements Checklist

  • Feature implemented / Bug fixed
@gkatsev

gkatsev approved these changes Nov 7, 2017

Can't really see an issue with this.
LGTM.

@misteroneill

misteroneill approved these changes Nov 7, 2017 edited

Fine with me, but I don't think we should get rid of getPluginVersion. There are cases where you want to know the version of a plugin registered without having to first initialize it on a player.

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Nov 7, 2017

Member

Oh, totally forgot about that part in the main comment. And yeah, this should be purely additive definitely usecase for the method as @misteroneill said.

Member

gkatsev commented Nov 7, 2017

Oh, totally forgot about that part in the main comment. And yeah, this should be purely additive definitely usecase for the method as @misteroneill said.

@BrandonOCasey

This comment has been minimized.

Show comment
Hide comment
@BrandonOCasey

BrandonOCasey Nov 7, 2017

Contributor

makes sense

Contributor

BrandonOCasey commented Nov 7, 2017

makes sense

@gkatsev gkatsev added confirmed minor and removed needs: LGTM labels Nov 7, 2017

@gkatsev gkatsev merged commit acf4153 into master Nov 7, 2017

4 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@gkatsev gkatsev deleted the feat/plugin-instance-version branch Nov 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment