New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: warning, if the element is not in the DOM #4723

Merged
merged 2 commits into from Nov 7, 2017

Conversation

Projects
None yet
3 participants
@odisei369
Copy link
Contributor

odisei369 commented Nov 6, 2017

Description

Add test to #4698

Specific Changes proposed

Test to make sure that warning is printed, when element given to Video.js is not in the DOM

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors
@gkatsev

gkatsev approved these changes Nov 7, 2017

Copy link
Member

gkatsev left a comment

Awesome, thanks @odisei369

@gkatsev gkatsev added confirmed and removed needs: LGTM labels Nov 7, 2017

@gkatsev gkatsev merged commit c213737 into videojs:master Nov 7, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment