New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor player.controls() #4731

Merged
merged 2 commits into from Nov 16, 2017

Conversation

Projects
None yet
3 participants
@kocoten1992
Contributor

kocoten1992 commented Nov 8, 2017

Requirements Checklist

  • refactor player.controls()
@gkatsev

Once again, thanks @kocoten1992!
This LGTM, though, we want to keep the jsdoc comments :)

if (bool) {
this.removeClass('vjs-controls-disabled');
this.addClass('vjs-controls-enabled');
/**

This comment has been minimized.

@gkatsev

gkatsev Nov 13, 2017

Member

can we restore the two jsdoc comments?

@gkatsev

gkatsev Nov 13, 2017

Member

can we restore the two jsdoc comments?

@gkatsev gkatsev added confirmed and removed needs: LGTM labels Nov 16, 2017

@gkatsev gkatsev merged commit d447e9f into videojs:master Nov 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment