New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid weird menu item tooltip title #4746

Merged
merged 1 commit into from Nov 16, 2017

Conversation

Projects
None yet
4 participants
@arski
Contributor

arski commented Nov 13, 2017

@gkatsev @misteroneill cc @luarmr I'd like to make this change to avoid having weird titles for the menu items in the player. You can easily reproduce the bug by keeping your mouse over any submenu item (caption language, video quality) on your own homepage e.g.

Note: Firefox just hides an empty-space tooltip, but this issue does pop up in Chrome, IE, likely others

before:
screen shot 2017-11-13 at 23 27 13

after:
screen shot 2017-11-13 at 23 26 57

@misteroneill

This LGTM, thanks @arski!

@arski

This comment has been minimized.

Show comment
Hide comment
@arski

arski Nov 14, 2017

Contributor

@misteroneill cool, whats the process for repeating this for the 5.x branch, is there a separate master for 5x?

Contributor

arski commented Nov 14, 2017

@misteroneill cool, whats the process for repeating this for the 5.x branch, is there a separate master for 5x?

@misteroneill

This comment has been minimized.

Show comment
Hide comment
@misteroneill

misteroneill Nov 14, 2017

Member

@arski Yeah, open a new PR against the 5.x branch.

Member

misteroneill commented Nov 14, 2017

@arski Yeah, open a new PR against the 5.x branch.

@arski arski referenced this pull request Nov 14, 2017

Merged

Avoid weird title #4747

@OwenEdwards

This comment has been minimized.

Show comment
Hide comment
@OwenEdwards

OwenEdwards Nov 15, 2017

Member

As the original author of this hack, this change definitely LGTM!

Member

OwenEdwards commented Nov 15, 2017

As the original author of this hack, this change definitely LGTM!

@gkatsev gkatsev added confirmed patch and removed needs: LGTM labels Nov 16, 2017

@gkatsev gkatsev merged commit dc588dd into videojs:master Nov 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

gkatsev added a commit that referenced this pull request Feb 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment