New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update tests to use qunit 2 assert format #4753

Merged
merged 3 commits into from Nov 16, 2017

Conversation

Projects
None yet
2 participants
@BrandonOCasey
Contributor

BrandonOCasey commented Nov 16, 2017

Description

We cannot change the package name from qunitjs to qunit at this time as karma-qunit does not support qunit only the qunitjs package name.

See: karma-runner/karma-qunit#98

Previously we stopped using an updated qunit as it did not support ie8. This may still be the case and we may not want to update qunit here at all.

This only came up because I wanted to use Qunit.timeout in some sourceset tests, but it isn't supported pre v2.

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Nov 16, 2017

Member

Yup, still broken. Not sure why one of the travises passed.
Oh, it thought no changes were made...

Member

gkatsev commented Nov 16, 2017

Yup, still broken. Not sure why one of the travises passed.
Oh, it thought no changes were made...

@gkatsev

If we revert the package-lock and package.json changes, we can pull in these changes.

Show outdated Hide outdated test/index.html Outdated
@BrandonOCasey

This comment has been minimized.

Show comment
Hide comment
@BrandonOCasey

BrandonOCasey Nov 16, 2017

Contributor

ok everything regarding the version update/name change should be reverted now.

Contributor

BrandonOCasey commented Nov 16, 2017

ok everything regarding the version update/name change should be reverted now.

@gkatsev gkatsev added the confirmed label Nov 16, 2017

@gkatsev gkatsev changed the title from test: update qunitjs to version 2, package now called qunit to test: update tests to use qunit 2 assert format Nov 16, 2017

@gkatsev gkatsev merged commit 06641e8 into master Nov 16, 2017

4 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@gkatsev gkatsev deleted the test/update-qunit branch Nov 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment