New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes TimeUI update on seek #4754

Merged
merged 3 commits into from Nov 17, 2017

Conversation

Projects
None yet
3 participants
@shahlabs
Contributor

shahlabs commented Nov 16, 2017

Description

TimeUpdate ui does not fire on seek when paused.

Specific Changes proposed

By manually triggering a timeupdate we force the ui to not use the cache.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors
@gkatsev

Seems like this improves things, particularly with Flash but doesn't completely fix it with Html5, still sporadically getting the time displays not updating in html5. This is good to be merged anyway since it improves things.
The whole seeking infrastructure in video.js needs to be overhauled, anyway.

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Nov 16, 2017

Member

Also, I updated the jsdoc comment.

Member

gkatsev commented Nov 16, 2017

Also, I updated the jsdoc comment.

@gkatsev gkatsev merged commit 1fcd5ae into videojs:master Nov 17, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment