New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only print dom warning on player creation #4755

merged 1 commit into from Nov 16, 2017


None yet
2 participants

BrandonOCasey commented Nov 16, 2017


Previously 'element is not in the dom' warnings would go off every time that we get a player from videojs. This change fixes that as well as a bug that would occur if the tag was passed in twice to video.js. This would cause the tag to technically not be in the dom as the element has changed, but the correct player is still returned.

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed

Makes sense.

@gkatsev gkatsev added the confirmed label Nov 16, 2017

@gkatsev gkatsev merged commit bbea5cc into master Nov 16, 2017

4 checks passed

continuous-integration/codeship Build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
deploy/netlify Deploy preview ready!

@gkatsev gkatsev deleted the fix/dont-print-dom-warn-twice branch Nov 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment