New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add `getPlayer` method to Video.js. #4836

Merged
merged 3 commits into from Jan 30, 2018

Conversation

Projects
None yet
3 participants
@misteroneill
Member

misteroneill commented Dec 21, 2017

There are cases where you want to get a player by an ID or an element, but not necessarily call videojs() to do it - because you don't want to create a player where one is absent.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
  • Reviewed by Two Core Contributors

misteroneill added some commits Dec 21, 2017

@gkatsev

This comment has been minimized.

Member

gkatsev commented Jan 23, 2018

test: ☑️

@gkatsev gkatsev added the tested label Jan 25, 2018

@gkatsev gkatsev merged commit a15e616 into videojs:master Jan 30, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

gkatsev added a commit that referenced this pull request Feb 22, 2018

fix: regression for getting a player via the tech's id (#4969)
As part of #4836, this piece of code was removed because it was thought it was not needed as everything else covers it. Turns out it's needed.

https://github.com/videojs/video.js/blob/f6eaa5e2ae417ffe27251133e1d1212cd9afa8e2/src/js/video.js#L103-L107

@misteroneill misteroneill deleted the misteroneill:feat/get-player branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment