New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: generate a test example on netlify on PRs #4912

Merged
merged 8 commits into from Jan 30, 2018

Conversation

Projects
None yet
2 participants
@gkatsev
Copy link
Member

gkatsev commented Jan 29, 2018

Sometimes, we get a small PR that has code that's good but testing it means that we have to check out the code locally. This should generate a test-example folder on the docs site for the PR with a built version of Video.js from the PR.
Hopefully, this PR will be the the very first example of it too.

@gkatsev

This comment has been minimized.

Copy link
Member Author

gkatsev commented Jan 29, 2018

@@ -449,7 +448,6 @@ module.exports = function(grunt) {
'cssmin',

'copy:fonts',
'copy:swf',

This comment has been minimized.

@gkatsev

gkatsev Jan 29, 2018

Author Member

our switch to node 8/npm 5 meant that packages were flattened, so, the swf snuck back into the dist folder.

@@ -16,4 +17,9 @@ if (process.env.BRANCH === 'master' && semver.valid(output.trim()) === null) {

// copy the legacy docs over
sh.cp('-R', 'docs/legacy-docs', 'docs/api/docs');

if (process.env.BRANCH !== 'master') {

This comment has been minimized.

@gkatsev

gkatsev Jan 29, 2018

Author Member

there's no need or want to generate this in the master branch currently, I don't think.


// copy the `dist` dir
sh.cp('-R', 'dist', path.join(dest, 'dist'));
sh.rm(path.join(dest, 'dist', `video-js-${pkg.version}.zip`));

This comment has been minimized.

@gkatsev

gkatsev Jan 29, 2018

Author Member

we don't need the zip file published here.

@@ -4,7 +4,7 @@
<meta charset="utf-8" />
<title>Video.js Icons Sandbox</title>

<link href="../build/temp/video-js.css" rel="stylesheet" type="text/css">
<link href="../build/video-js.css" rel="stylesheet" type="text/css">

This comment has been minimized.

@misteroneill

misteroneill Jan 29, 2018

Member

Is this one intentionally using build instead of dist?

This comment has been minimized.

@gkatsev

gkatsev Jan 29, 2018

Author Member

nope. Probably got confused about it, heh.

@gkatsev gkatsev merged commit 8b54737 into master Jan 30, 2018

4 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@gkatsev gkatsev deleted the build-test-file branch Jan 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment