New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware): do a null check in mediator methods #4913

Merged
merged 2 commits into from Jan 31, 2018

Conversation

Projects
None yet
2 participants
@gkatsev
Member

gkatsev commented Jan 30, 2018

No description provided.

}
});
middleware.mediate([mwFactory(), mwFactory2()], {pause: () => {}}, 'pause');

This comment has been minimized.

@gkatsev

gkatsev Jan 30, 2018

Member

This will throw and thus fail the test without the change in middleware.js.

@gkatsev gkatsev requested a review from ldayananda Jan 30, 2018

@ldayananda

LGTM. Thanks again for the fix

@gkatsev gkatsev merged commit 7670db6 into master Jan 31, 2018

4 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@gkatsev gkatsev deleted the mw-mediator-check-fn branch Jan 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment