New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duration reset, and allow duration NaN or 0 for duration display #5348

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
4 participants
@fketchakeu
Copy link
Contributor

fketchakeu commented Jul 26, 2018

Description

This resets the duration display when a new media item is loaded with preload set to 'none', and allows the duration NaN or 0 to update the duration display.

Fixes videojs/video.js#3927

fix: duration reset, and allow duration NaN or 0 for duration display
This allows the duration NaN or 0 to update the duration display.
This also resets the duration display when a new media item is loaded with `preload` set to 'none'.

Fixes #5347
@thijstriemstra

This comment has been minimized.

Copy link
Contributor

thijstriemstra commented Aug 3, 2018

I'm not a fan of these event listeners inside the controls. My plugins manually update the currentime and duration displays and I manually disable these listeners, and with this PR yet another listener would be added that I'd have to disable.

@gkatsev

This comment has been minimized.

Copy link
Member

gkatsev commented Aug 3, 2018

Having the controls listening to these events make them self contained instead of having something else be reaching in and updating them. In Video.js 6 with middleware, you can more easily make these controls output whatever you want instead.

@stale

This comment has been minimized.

Copy link

stale bot commented Oct 2, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 2, 2018

@gkatsev gkatsev removed the wontfix label Oct 2, 2018

@gkatsev gkatsev added the needs: LGTM label Nov 13, 2018

@gkatsev gkatsev merged commit ab0e29a into videojs:master Nov 14, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Nov 14, 2018

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment