New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vjs-lock-showing class gets removed from menu when no longer hovering on menu-button. #5465

Merged
merged 6 commits into from Nov 2, 2018

Conversation

Projects
None yet
5 participants
@gjanblaszczyk
Copy link
Contributor

gjanblaszczyk commented Oct 1, 2018

Description

A proposed fix for #1690

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

gjanblaszczyk added some commits Sep 3, 2018

Merge pull request #1 from videojs/master
sync with origin branch
@gkatsev

This comment has been minimized.

Copy link
Member

gkatsev commented Oct 1, 2018

Thanks for the PR! This is a great start. We've had some discussion about what the ideal behavior should be in #5404. Would you be up for updating it to fit more in line with that one? I think the main task left is that clicking anywhere that isn't inside the menu should also close the menu.

@gjanblaszczyk

This comment has been minimized.

Copy link
Contributor Author

gjanblaszczyk commented Oct 2, 2018

Np @gkatsev, I added changes that should also fix the problem described in #5404. Please, let me know if something isn't working as expected.

@gkatsev

This comment has been minimized.

Copy link
Member

gkatsev commented Oct 2, 2018

Thanks @gjanblaszczyk! Works well in the example https://deploy-preview-5465--videojs-docs.netlify.com/test-example/

@OwenEdwards did you have any comments to add?

@gkatsev

gkatsev approved these changes Oct 2, 2018

@OwenEdwards
Copy link
Member

OwenEdwards left a comment

LGTM

@gkatsev gkatsev merged commit 58f638e into videojs:master Nov 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@gkatsev gkatsev referenced this pull request Dec 18, 2018

Closed

feat: Close subtitles menu when clicking the seek bar #5688

3 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment