Feat: add 'replay' option to the PlayToggle component. #5531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync with origin branch
There was a problem hiding this comment.
Looks good to me as-is. Especially nice that you updated the documentation!
I wonder if this is a situation where we'd want to have a replay() getter/setter method? That could make this toggle-able at runtime. Thoughts @gkatsev?
|
Thanks @misteroneill, |
|
Yeah, I don't think it's worth it. We can add it in later if someone requests it. |
gkatsev
approved these changes
Nov 2, 2018
|
how can replay/restart videos programatically from start? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A proposed fix for #4802
Specific Changes proposed
I added 'replay' option to the PlayToggle component.
Requirements Checklist