Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove vjs-waiting until time changes #5533

Merged

Conversation

@gesinger
Copy link
Contributor

@gesinger gesinger commented Oct 29, 2018

Description

Sometimes the vjs-waiting class is removed prematurely after the player gets into a waiting state. This removes the graphic waiting spinner while the player is still waiting. To see this behavior on Chrome:

  1. Go to https://videojs.github.io/http-streaming/
  2. Open the console
  3. Enter:
player.on('waiting', () => console.log('waiting'));
player.on('timeupdate', () => console.log('timeupdate: ' + player.currentTime()));
player.play();
  1. Click "Offline" in the network tab

The console logs timeupdate events of the same time sandwiching a waiting event, e.g.:

...
timeupdate: 49.675262
timeupdate: 49.812381
waiting
timeupdate: 49.812381

Specific Changes proposed

This PR waits to remove the vjs-waiting class until the time changes on timeupdate events.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors
@gkatsev
gkatsev approved these changes Nov 2, 2018
@gkatsev gkatsev merged commit 0060747 into videojs:master Nov 2, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@squarebracket squarebracket mentioned this pull request Jan 11, 2019
3 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants