-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lang): es6 import of a language file #5549
Conversation
copy all json files to dist/lang directory. related issue: #5092
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
This may be a reasonable workaround. Is importing JSON something that's actively supported? Or is that why you mention the need to enable it in TS? |
It's supported. |
Looking at the standard itself, it doesn't support importing JSON directly. However, this may be a decent workaround until we figure out a better way of supporting ESM directly. |
This is the quickest patch, the longer one is to create another directory with module.exports js files. What do you think? |
Yeah, I think this is fine. |
Going to merge even though the tests are failing as it's unrelated and may not be an issue in master. We're still investigating why the tests are failing. |
Congrats on merging your first pull request! 🎉🎉🎉 |
Description
A temporary solution to enable es6 import of the language files.
Related issue: #5092
How to use:
If you use typescript, you need to add the following compilerOptions to the tsconfig:
Specific Changes proposed
Add a grunt task to copy all json files to dist/lang directory.
Requirements Checklist