Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps, remove coveralls, fix audit issues #5555

merged 4 commits into from Nov 6, 2018


Copy link

@gkatsev gkatsev commented Nov 6, 2018

Also, run npm audit. Then remove grunt-coveralls because it isn't used and coverage will be added separately. The last audit issue is waiting on karma-runner/karma-browserstack-launcher#135
replace was updated to 1.0 when ownership changed and security issues were fixed.

@@ -89,7 +89,7 @@
"conventional-changelog-cli": "^2.0.11",
"conventional-changelog-videojs": "^3.0.0",
"es5-shim": "^4.5.10",
Copy link

@brandonocasey brandonocasey Nov 6, 2018

I have been wondering this, can we remove es5-shim at this point?

Copy link
Member Author

@gkatsev gkatsev Nov 6, 2018

Maybe, it doesn't hurt to keep it in. It's only used for tests and helps make sure everything is up-to-spec. Since we're loading in es6-shim and es7-shim, it's probably best to keep es5-shim as well.

@gkatsev gkatsev changed the title WIP: Update deps chore: update deps, remove coveralls, fix audit issues Nov 6, 2018
@gkatsev gkatsev merged commit 11f1fb8 into master Nov 6, 2018
4 checks passed
@gkatsev gkatsev deleted the update-deps branch Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants