New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Welsh/Cymraeg (cy) translations #5561

merged 2 commits into from Nov 8, 2018


None yet
3 participants
Copy link

carlmorris commented Nov 7, 2018


Add completed translations for Welsh/Cymraeg.

Specific Changes proposed

New file of Welsh/Cymraeg (cy) language strings.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

This comment has been minimized.

Copy link

welcome bot commented Nov 7, 2018

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link

misteroneill left a comment

Tests are failing, but that's unrelated to this PR. It may need to be rebased on the latest master branch.

Thanks for the PR!


gkatsev approved these changes Nov 8, 2018


This comment has been minimized.

Copy link

gkatsev commented Nov 8, 2018

Merging even though tests failed, as they're unrelated.

@gkatsev gkatsev merged commit b2c1077 into videojs:master Nov 8, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
netlify/videojs-docs/deploy-preview Deploy preview ready!

This comment has been minimized.

Copy link

welcome bot commented Nov 8, 2018

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment