Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct error type number matches #5566

Merged
merged 1 commit into from Nov 9, 2018
Merged

Correct error type number matches #5566

merged 1 commit into from Nov 9, 2018

Conversation

@bartlomein
Copy link
Contributor

@bartlomein bartlomein commented Nov 9, 2018

Description

Fixed as was specified in the issue.

Specific Changes proposed

Changes as specified.

Requirements Checklist

  • [ X ] Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors
@welcome
Copy link

@welcome welcome bot commented Nov 9, 2018

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

gkatsev
gkatsev approved these changes Nov 9, 2018
@gkatsev gkatsev mentioned this pull request Nov 9, 2018
7 tasks
@gkatsev gkatsev merged commit 441f0e1 into master Nov 9, 2018
4 checks passed
@welcome
Copy link

@welcome welcome bot commented Nov 9, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@gkatsev gkatsev deleted the first-timers-error-types branch Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants