-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update starter template #5570
Conversation
Use a codepen template for the starter template that includes a 7.x player, video-js element, and a JavaScript created player. The template is https://codepen.io/gkatsev/pen/GwZegv?editors=1010#0 Fixes #5562
is there any way that we can use unpkg or something for this? That way we don't have to remember to update the version. |
I could update the template. |
Updated |
Also, with this template, it means I can update it without the url changing |
My concern with this example is that it actually might be too advanced for some of our users! Having an example using plain HTML and JavaScript, like in the "Getting Started" example, might mean that some users are more likely to create a simple example of an issue they report. EDIT: It's also not obvious (to me, and therefore I assume to some other less experienced users) where, in the Codepen, you include the video.js files. I dug around and found them, but the old JS Bin put them right there in the HTML editor. |
Ah, yeah, makes sense, let me move it out of settings then. |
mostly looks good, I would change the second empty object that is passed to |
I updated the template to use data-setup again and not using any javascript. I moved the script and styles back into the html. I then updated the links to hide the javascript panel by default. |
I think it would make sense to still get a reference to the player in the js panel, even if we hide the panel. Other than that LGTM |
I agree that there ought to be some JS that references the player, again, like in the https://github.com/videojs/video.js#quick-start. Also, you're still using a |
@OwenEdwards I updated it to switch to Also, just realized that codepen has a collection feature, so, we could make a bunch of collections of various other templates, like one with |
Would it make sense to be more consistent with self-closing tags (e.g. Looks fine overall. |
Merged. I can update the codepen as/if necessary. |
Use a codepen template for the starter template that includes a 7.x
player, video-js element, and a JavaScript created player.
The template is https://codepen.io/gkatsev/pen/GwZegv?editors=1010#0
Fixes #5562