Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove problematic secret variables #5577

merged 1 commit into from Nov 13, 2018

ci: remove problematic secret variables #5577

merged 1 commit into from Nov 13, 2018


Copy link

@DanielRuf DanielRuf commented Nov 13, 2018


Please describe the change as necessary.
If it's a feature or enhancement please be as detailed as possible.
If it's a bug fix, please link the issue that it fixes or describe the bug in as much detail.

Specific Changes proposed

Two environment variables are not correctly encrypted and produce failing builds.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Copy link

@gkatsev gkatsev left a comment

Looks like they were added for saucelabs testing (4a62ebb#diff-354f30a63fb0907d4ad57269548329e3) which we no longer use

@gkatsev gkatsev merged commit 15beea7 into videojs:master Nov 13, 2018
1 of 2 checks passed
Copy link

@welcome welcome bot commented Nov 13, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@DanielRuf DanielRuf deleted the ci/remove-problematic-secret-variables branch Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants