Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Add the Occitan locale #5578

Merged
merged 1 commit into from Nov 14, 2018
Merged

[i18n] Add the Occitan locale #5578

merged 1 commit into from Nov 14, 2018

Conversation

@Quenty31
Copy link
Contributor

@Quenty31 Quenty31 commented Nov 13, 2018

Description

Adds the Occitan language, talked in South France, North Spain, Monaco and North Italy.
It's based on the translation of PeerTube

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors
@welcome
Copy link

@welcome welcome bot commented Nov 13, 2018

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link
Member

@gkatsev gkatsev left a comment

Thanks!

@Quenty31
Copy link
Contributor Author

@Quenty31 Quenty31 commented Nov 13, 2018

What kind o LGTM do you need?

@gkatsev
Copy link
Member

@gkatsev gkatsev commented Nov 13, 2018

@Quenty31 hey, nothing else needed from you. Our process generally requires two reviewers to look at a PR before it can be merged. That label signifies that one person has looked at it and just needs another set of eyes.

Copy link
Member

@misteroneill misteroneill left a comment

Thanks!

@gkatsev
Copy link
Member

@gkatsev gkatsev commented Nov 14, 2018

Test failures are separate, merging.

@gkatsev gkatsev merged commit 0fb637d into videojs:master Nov 14, 2018
1 of 2 checks passed
@welcome
Copy link

@welcome welcome bot commented Nov 14, 2018

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants