New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Lint on pre-commit with lint-staged, use npm-merge-driver #5591

Merged
merged 3 commits into from Nov 16, 2018

Conversation

Projects
None yet
2 participants
@BrandonOCasey
Copy link
Contributor

BrandonOCasey commented Nov 14, 2018

Not having lint-staged or npm-merge-driver-install has been bugging me, they make the workflow a lot quicker when committing or merging package-lock changes. It also allows us to only lint the partially staged changes that we are working on during commit/push.

Show resolved Hide resolved package.json Outdated

@BrandonOCasey BrandonOCasey force-pushed the chore/smarter-tooling branch from cebd601 to 42e10a2 Nov 15, 2018

@gkatsev gkatsev merged commit be9e9a9 into master Nov 16, 2018

4 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
netlify/videojs-docs/deploy-preview Deploy preview ready!
Details

@gkatsev gkatsev deleted the chore/smarter-tooling branch Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment