New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default subtitles not enabled #5608

Merged
merged 2 commits into from Nov 29, 2018

Conversation

Projects
None yet
2 participants
@alex-barstow
Copy link
Contributor

alex-barstow commented Nov 20, 2018

Description

This is a follow-up to this fix in VHS, after which default in-manifest subtitles were still not being correctly enabled. The reason is because video.js's text track preselection logic was running before the media groups were set up in VHS.

Solution

Text track preselection should happen on 'loadedmetadata' instead of 'loadstart'. According to the HTML spec, text track data is available on 'loadedmetadata', so we should be waiting until then to make preselection decisions.

Test content w/ default subtitles: https://bitdash-a.akamaihd.net/content/sintel/hls/playlist.m3u8

@gkatsev
Copy link
Member

gkatsev left a comment

This totally makes sense.

@alex-barstow alex-barstow force-pushed the alex-barstow:fix-default-captions branch from 627accc to 39f6a21 Nov 29, 2018

@gkatsev gkatsev merged commit 8329e64 into videojs:master Nov 29, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/videojs-docs/deploy-preview Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment