Tests/fix travis#5627
Merged
gkatsev merged 4 commits intovideojs:masterfrom Nov 28, 2018
brandonocasey:tests/fix-travis
Merged
Conversation
brandonocasey
commented
Nov 28, 2018
| language: node_js | ||
| node_js: | ||
| - lts/* | ||
| cache: npm |
Contributor
Author
There was a problem hiding this comment.
Travis now supports a better method of cacheing
brandonocasey
commented
Nov 28, 2018
|
|
||
| // disable warning logs for sourceset tests, by proxing to a remote host | ||
| Object.assign(config.proxies, { | ||
| '/test/relative-one.mp4': 'http://example.com/relative-one.mp4', |
Contributor
Author
There was a problem hiding this comment.
This fixes warning logs in karma
brandonocasey
commented
Nov 28, 2018
| }; | ||
| const testSrc = { | ||
| src: 'http://vjs.zencdn.net/v/oceans.mp4', | ||
| src: 'http://example.com/testSrc.mp4', |
Contributor
Author
There was a problem hiding this comment.
We should just point to a fake source
Member
|
This fixes #5616 |
gkatsev
approved these changes
Nov 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request does three things:
This should fix tests on travis by stopping tests from running on Firefox in travis. Tests will still run on browserstack Firefox. Testing on firefox was added in chore: switch to videojs-generate-karma-config #5528, an investigation issue to get this working has been created as Find out why Travis Firefox tests fail #5626
This pull request also updates the travis config as outlined in: https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration
Finally this pull request silences the logging from sourceset tests
Fixes #5616