Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upfix: liveui tweaks #5650
Conversation
BrandonOCasey
added some commits
Dec 3, 2018
BrandonOCasey
force-pushed the
fix/liveui-tweaks
branch
from
7974551
to
7ebe0d7
Dec 4, 2018
BrandonOCasey
changed the title
Fix/liveui tweaks
fix: liveui tweaks
Dec 4, 2018
gkatsev
reviewed
Dec 5, 2018
src/js/live-tracker.js Outdated
This comment has been minimized.
This comment has been minimized.
|
This is a great change towards making the button seek to "live" asap. In another PR, we probably need to do @gesinger's suggestion of looseing up what "at edge" means as I can see the inidicator toggling between grey and red during regular playback. |
gkatsev
approved these changes
Dec 6, 2018
gkatsev
merged commit 831961b
into
master
Dec 6, 2018
gkatsev
deleted the
fix/liveui-tweaks
branch
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
BrandonOCasey commentedDec 4, 2018
•
edited
Changes
seekablevalue in the video element, so we use that to seek to live, rather than waiting for a seekable end change.