Skip to content

/ video.js Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: liveui tweaks #5650

Merged
merged 6 commits into from Dec 6, 2018
Merged

fix: liveui tweaks #5650

merged 6 commits into from Dec 6, 2018
+43 −38

Conversation

@brandonocasey
Copy link
Contributor

@brandonocasey brandonocasey commented Dec 4, 2018 •
edited

Changes

  1. Make sure that we seek to live playback on the first timeupdate
  2. Do not report that we are not live before playback has started (a timeupdate has been seen)
  3. Prevent negative seekable increments
  4. We can seek past the seekable value in the video element, so we use that to seek to live, rather than waiting for a seekable end change.
@brandonocasey
feat: seek to live edge on first timeupdate after firstplay
06ae4e1
@brandonocasey
use liveCurrentTime
fbfc393
@brandonocasey
prevent negative seekable increment
9940f9b
@brandonocasey
prevent reporting not live before the video has started
7ebe0d7
@brandonocasey brandonocasey changed the title Fix/liveui tweaks fix: liveui tweaks Dec 4, 2018
@brandonocasey
fix the tests
e09be9f
misteroneill
misteroneill reviewed Dec 5, 2018
View changes
Copy link
Member

@misteroneill misteroneill left a comment

One question.

test/unit/live-tracker.test.js Show resolved Hide resolved
gkatsev
gkatsev reviewed Dec 5, 2018
View changes
src/js/live-tracker.js Outdated Show resolved Hide resolved
@gkatsev
Copy link
Member

@gkatsev gkatsev commented Dec 5, 2018

This is a great change towards making the button seek to "live" asap. In another PR, we probably need to do @gesinger's suggestion of looseing up what "at edge" means as I can see the inidicator toggling between grey and red during regular playback.

@brandonocasey
cr and cleanup
dd36d4d
gkatsev
gkatsev approved these changes Dec 6, 2018
View changes
@gkatsev gkatsev merged commit 831961b into master Dec 6, 2018
4 checks passed
@gkatsev gkatsev deleted the fix/liveui-tweaks branch Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill

@gkatsev gkatsev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@brandonocasey @gkatsev @misteroneill