New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: liveui tweaks #5650

Merged
merged 6 commits into from Dec 6, 2018

Conversation

Projects
None yet
3 participants
@BrandonOCasey
Copy link
Contributor

BrandonOCasey commented Dec 4, 2018

Changes

  1. Make sure that we seek to live playback on the first timeupdate
  2. Do not report that we are not live before playback has started (a timeupdate has been seen)
  3. Prevent negative seekable increments
  4. We can seek past the seekable value in the video element, so we use that to seek to live, rather than waiting for a seekable end change.

@BrandonOCasey BrandonOCasey force-pushed the fix/liveui-tweaks branch from 7974551 to 7ebe0d7 Dec 4, 2018

@BrandonOCasey BrandonOCasey changed the title Fix/liveui tweaks fix: liveui tweaks Dec 4, 2018

@misteroneill
Copy link
Member

misteroneill left a comment

One question.

Show resolved Hide resolved test/unit/live-tracker.test.js
Show resolved Hide resolved src/js/live-tracker.js Outdated
@gkatsev

This comment has been minimized.

Copy link
Member

gkatsev commented Dec 5, 2018

This is a great change towards making the button seek to "live" asap. In another PR, we probably need to do @gesinger's suggestion of looseing up what "at edge" means as I can see the inidicator toggling between grey and red during regular playback.

@gkatsev

gkatsev approved these changes Dec 6, 2018

@gkatsev gkatsev merged commit 831961b into master Dec 6, 2018

4 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
netlify/videojs-docs/deploy-preview Deploy preview ready!
Details

@gkatsev gkatsev deleted the fix/liveui-tweaks branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment