Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hidden Control Text in Progress bar (Fixes #5251) #5655

Conversation

OwenEdwards
Copy link
Member

Description

Fix the hidden Control Text (intended for screen reader users) in the Progress Bar, which never gets updated by loading or playback. Fixes #5251.

Specific Changes proposed

  • Update the Control Text in the load-progress-bar during loading
  • Remove unnecessary Control Text from the play-progress-bar
  • Hide the time-tooltip feature from Assistive Technology using ARIA.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

…ve unnecessary Control Text from the play-progress-bar, and hide the time-tooltip feature from Assistive Technology using ARIA.
@gkatsev gkatsev added the patch label Dec 10, 2018
…ress-bar, and use that for the text to update.
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Owen! 👍

@gkatsev gkatsev added the a11y This item might affect the accessibility of the player label Dec 11, 2018
@gkatsev gkatsev merged commit 70a71ae into videojs:master Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y This item might affect the accessibility of the player patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The progress bar has hidden text (for screen reader users) which does not get updated
3 participants