New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hidden Control Text in Progress bar (Fixes #5251) #5655

Merged
merged 2 commits into from Dec 11, 2018

Conversation

Projects
None yet
3 participants
@OwenEdwards
Copy link
Member

OwenEdwards commented Dec 5, 2018

Description

Fix the hidden Control Text (intended for screen reader users) in the Progress Bar, which never gets updated by loading or playback. Fixes #5251.

Specific Changes proposed

  • Update the Control Text in the load-progress-bar during loading
  • Remove unnecessary Control Text from the play-progress-bar
  • Hide the time-tooltip feature from Assistive Technology using ARIA.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors
Update the Control Text in the load-progress-bar during loading, remo…
…ve unnecessary Control Text from the play-progress-bar, and hide the time-tooltip feature from Assistive Technology using ARIA.

@gkatsev gkatsev added the patch label Dec 10, 2018

Add a span around the vjs-control-text-loaded-percentage in load-prog…
…ress-bar, and use that for the text to update.
@misteroneill
Copy link
Member

misteroneill left a comment

Thanks, Owen! 👍

@gkatsev gkatsev added the a11y label Dec 11, 2018

@gkatsev gkatsev merged commit 70a71ae into videojs:master Dec 11, 2018

3 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment