New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add a test to check various children set to false #5670

Merged
merged 4 commits into from Dec 11, 2018

Conversation

Projects
None yet
3 participants
@BrandonOCasey
Copy link
Contributor

BrandonOCasey commented Dec 10, 2018

  • Added a test that should catch assertions that happen when a child is turned off on the player.
  • About to add a fix for the current assertion on liveTracker/seekToLive.
Show resolved Hide resolved test/unit/player.test.js Outdated

@BrandonOCasey BrandonOCasey force-pushed the fix/livetracker-null-check branch from 46aa738 to ef5f298 Dec 10, 2018

@gkatsev gkatsev changed the title tests: add a test to check various children set to false test: add a test to check various children set to false Dec 11, 2018

@gkatsev gkatsev added the patch label Dec 11, 2018

@BrandonOCasey BrandonOCasey force-pushed the fix/livetracker-null-check branch from 5f99de4 to 16a5257 Dec 11, 2018

@BrandonOCasey BrandonOCasey force-pushed the fix/livetracker-null-check branch from 16a5257 to 5a503ab Dec 11, 2018

@BrandonOCasey BrandonOCasey force-pushed the fix/livetracker-null-check branch from 5a503ab to 0b66579 Dec 11, 2018

@gkatsev

This comment has been minimized.

Copy link
Member

gkatsev commented Dec 11, 2018

Can the sed command be run to fix the https->http issue in package-lock? Otherwise, LGTM

@BrandonOCasey

This comment has been minimized.

Copy link
Contributor Author

BrandonOCasey commented Dec 11, 2018

sed command done

@gkatsev gkatsev merged commit 13b42ad into master Dec 11, 2018

4 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
netlify/videojs-docs/deploy-preview Deploy preview ready!
Details

@gkatsev gkatsev deleted the fix/livetracker-null-check branch Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment