New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the "-" in remaining-time-display.js so it is not announced by screen readers. Fixes #5168 #5671

Merged
merged 4 commits into from Jan 4, 2019

Conversation

Projects
None yet
3 participants
@smbea
Copy link
Contributor

smbea commented Dec 11, 2018

Description

Fixes issue #5168 @gkatsev
Remaining time is now a positive value by it's own and the negative sign is added decoratively.

Specific Changes proposed

  • Removed negative sign in when returning the remaining time
  • Added the negative ('-') sign to the number's container and make it 'aria-hidden' so screen readers can't read it

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors
@welcome

This comment has been minimized.

Copy link

welcome bot commented Dec 11, 2018

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@gkatsev gkatsev added minor patch and removed minor labels Dec 11, 2018

@OwenEdwards OwenEdwards changed the title fixed issue 5168 Move the "-" in remaining-time-display.js so it is not announced by screen readers. Fixes #5168 Dec 11, 2018

@gkatsev gkatsev added the a11y label Dec 18, 2018

@gkatsev
Copy link
Member

gkatsev left a comment

Thanks! LGTM.
@OwenEdwards can you take a look?

@gkatsev gkatsev requested a review from OwenEdwards Dec 18, 2018

@gkatsev gkatsev added the needs: LGTM label Dec 19, 2018

@OwenEdwards
Copy link
Member

OwenEdwards left a comment

@gkatsev I think this needs this one change, just for consistency/clarity. Otherwise, it LGTM.

gkatsev added some commits Jan 4, 2019

@gkatsev gkatsev added this to the 7.4.x milestone Jan 4, 2019

@gkatsev gkatsev removed the needs: updates label Jan 4, 2019

@OwenEdwards OwenEdwards removed the needs: LGTM label Jan 4, 2019

@gkatsev gkatsev merged commit 9a8376e into videojs:master Jan 4, 2019

1 of 2 checks passed

netlify/videojs-docs/deploy-preview Deploy preview failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Jan 4, 2019

Congrats on merging your first pull request! 🎉🎉🎉

gkatsev added a commit that referenced this pull request Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment