Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the "-" in remaining-time-display.js so it is not announced by screen readers. Fixes #5168 #5671

Merged
merged 4 commits into from Jan 4, 2019

Conversation

@smbea
Copy link
Contributor

@smbea smbea commented Dec 11, 2018

Description

Fixes issue #5168 @gkatsev
Remaining time is now a positive value by it's own and the negative sign is added decoratively.

Specific Changes proposed

  • Removed negative sign in when returning the remaining time
  • Added the negative ('-') sign to the number's container and make it 'aria-hidden' so screen readers can't read it

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors
@welcome
Copy link

@welcome welcome bot commented Dec 11, 2018

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@OwenEdwards OwenEdwards changed the title fixed issue 5168 Move the "-" in remaining-time-display.js so it is not announced by screen readers. Fixes #5168 Dec 11, 2018
Copy link
Member

@gkatsev gkatsev left a comment

Thanks! LGTM.
@OwenEdwards can you take a look?

@gkatsev gkatsev requested a review from OwenEdwards Dec 18, 2018
Copy link
Member

@OwenEdwards OwenEdwards left a comment

@gkatsev I think this needs this one change, just for consistency/clarity. Otherwise, it LGTM.

@gkatsev gkatsev added this to the 7.4.x milestone Jan 4, 2019
@gkatsev gkatsev merged commit 9a8376e into videojs:master Jan 4, 2019
1 of 2 checks passed
@welcome
Copy link

@welcome welcome bot commented Jan 4, 2019

Congrats on merging your first pull request! 🎉🎉🎉

gkatsev added a commit that referenced this issue Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants