Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: remove child from old parent when moving to new parent via addChild #5702
A child component may have been assigned to another
Specific Changes proposed
Remove the specific child component from the old parent component before adding the child component to the new parent
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
Dec 20, 2018
So, the reason for this is so that the internal
Yes, for example, if I want to add the new menu item of the menu button dynamically, a class can be implemented as follows:
But what i found is whenever the "MutableMenuButton".inserItem gets called, the existed menu item is removed from the new menu that belongs to the menu button.
So that is why I commit this change, if you think that is acceptable, I will add some tests.