-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(seekbar): don't disable if live tracker's seekable is infinity #5721
Conversation
The seekbar is disabled if the seekable end is Infinity and re-enabled when it isn't. Instead, we should only disable if seekable end is Infinity and re-enable only if we disabled for the seekable end. This auto disabling and re-enabling, without this fix, caused issues with disabling the progress control since the seekbar got re-enabled.
So, spoke with @ldayananda offline.
|
Another option is to just remove this block as well. |
So, we've decided to just remove the code in question so it doesn't cause any potential issues. We recommend users on Android overrideNative to use our MSE-based playback engine. |
…5721) This was done to make the behavior on Android with HLS live streams better but the it's opening us up to too many potential issues, like a user not being able to properly disable the control bar, that we should just back it out.
The seekbar is disabled if the seekable end is Infinity and re-enabled
when it isn't. Instead, we should only disable if seekable end is
Infinity and re-enable only if we disabled for the seekable end.
This auto disabling and re-enabling, without this fix, caused issues
with disabling the progress control since the seekbar got re-enabled.