Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(player): remove vjs-ended class on seeked #5728

Merged
merged 1 commit into from Jan 8, 2019
Merged

fix(player): remove vjs-ended class on seeked #5728

merged 1 commit into from Jan 8, 2019

Conversation

@gkatsev
Copy link
Member

@gkatsev gkatsev commented Jan 4, 2019

Whenever we seek after the video has ended, we are no longer ended and
therefore we should remove the vjs-ended class.

Fixes #5654.

Whenever we seek after the video has ended, we are no longer ended and
therefore we should remove the vjs-ended class.

Fixes #5654.
Copy link
Member

@misteroneill misteroneill left a comment

Well, that's excessively reasonable.

@gkatsev gkatsev merged commit 544ed9d into master Jan 8, 2019
4 checks passed
@gkatsev gkatsev deleted the vjs-ended branch Jan 8, 2019
gkatsev added a commit that referenced this issue Jan 8, 2019
Whenever we seek after the video has ended, we are no longer ended and
therefore we should remove the vjs-ended class.

Fixes #5654.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants