Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send playing before prerolls, just after (and major commenting for redispatch) #187

Merged
merged 6 commits into from Sep 29, 2016

Conversation

incompl
Copy link
Contributor

@incompl incompl commented Sep 21, 2016

No description provided.

@incompl incompl changed the title [WIP] Refactor redispatch Don't send playing before prerolls, just after (and major commenting for redispatch) Sep 22, 2016

// When ad is playing in content tech, prefix everything with "ad".
// This block catches many events such as emptied, play, timeupdate, and ended.
} else if (player.ads.state === 'ad-playback') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change and think this makes the event flow much easier to follow. However, this is likely to affect other plugins relying on these events and so should be thoroughly documented.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I already know of one place where the change to "playing" would break something else. This will be tricky

@ldayananda
Copy link
Contributor

LGTM

@pagarwal123
Copy link

QA: LGTM

@incompl incompl merged commit 17acfdf into master Sep 29, 2016
@incompl incompl deleted the refactor-redispatch branch September 29, 2016 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants