fix: handle initial duplicate webkitneedskey #134
Conversation
src/plugin.js
Outdated
| player.eme.webkitneedkey.first = true; | ||
| player.eme.webkitneedkey.timeout = null; | ||
| handleFn(event); | ||
| }, 1000); |
There was a problem hiding this comment.
So, this means that safari+fairplay will always take at least 1s to start playback? Should we make this value configurable?
There was a problem hiding this comment.
I will add a configuration option but default it to 1000ms. How does that sound?
There was a problem hiding this comment.
Sounds fine to me. Was there a smaller value that you found worked or is 1s the most reliable you've found?
| // (also used in early Chrome or Chrome with EME disabled flag) | ||
| player.tech_.el_.addEventListener('webkitneedkey', (event) => { | ||
| // It's possible that at the start of playback a rendition switch | ||
| // on a small player in safari's HLS implementation will cause |
There was a problem hiding this comment.
Does it have to be a small player?
There was a problem hiding this comment.
makes it more likely since they'll start with a lower rendition. Happens a lot less if you have the window maximized.
| // It's possible that at the start of playback a rendition switch | ||
| // on a small player in safari's HLS implementation will cause | ||
| // two webkitneedkey events to occur. We want to make sure to cancel | ||
| // our first existing request if we get another within 1 second. This |
There was a problem hiding this comment.
Is there any reasoning behind 1 second that we can mention?
There was a problem hiding this comment.
It was typically happening from 250ms to 750ms for me
| // prevents a non-fatal player error from showing up due to a | ||
| // request failure. | ||
| if (!player.eme.webkitneedkey_.seenFirstEvent) { | ||
| player.clearTimeout(player.eme.webkitneedkey_.timeout); |
There was a problem hiding this comment.
I know that there's not much we can do, but if Safari ever decides to keep firing webkitneedkey events within the 1 second duration we'll keep clearing and creating new timeouts. That would probably be a bigger issue for them to fix though.
| // request failure. | ||
| if (!player.eme.webkitneedkey_.seenFirstEvent) { | ||
| player.clearTimeout(player.eme.webkitneedkey_.timeout); | ||
| player.eme.webkitneedkey_.timeout = player.setTimeout(() => { |
There was a problem hiding this comment.
We may want to clear out this timeout on source changes
There was a problem hiding this comment.
added a check for this.
brandonocasey
force-pushed
the
fix/fairplay-duplicate
branch
from
7334751
to
7f3bae6
Compare
Fixes an issues where safari will trigger a
webkitneedskeyon a rendition and then switch renditions and trigger another one.shaka-project/shaka-player#2426