Settings: Actionsheet by mkchoi212 · Pull Request #102 · videolan/vlc-ios

mkchoi212 · 2018-07-23T05:56:21Z

Checklist

I've run bundle exec fastlane test from the root directory to see all new and existing tests pass
I've followed the vlc-ios code style and run bundle exec fastlane lint to ensure the code style is valid
I've read the Contribution Guidelines
I've updated the documentation if necessary.

Description

Must be rebased after the settings PR is merged

Instead of pushing a new view to adjust the settings, VLCActionSheet is used.

mkchoi212 · 2018-07-23T07:20:13Z

Sources/VLCActionSheet/VLCActionSheetCell.swift

+    let checkmark: UILabel = {
+        let checkmark = UILabel()
+        checkmark.text = "✓"
+        checkmark.font = UIFont.systemFont(ofSize: 15)


Should this be bigger?

Indeed, It's a bit small but I wonder if this shouldn't be a separate class. For example perhaps a VLCSettingSheetCell?

Also, open thought, I'm aware that on Figma the checkmark is on the right but shouldn't we consider putting the check mark on the left like the edit mode? Might just be a personal preference but I think it will be nicer 😅

Not all ActionSheet cells need/will need checkmarks.

So for the few that need both checkmarks and images, it should be placed on the right, no?

Just subclassed it to VLCSettingSheetCell and it makes more sense :D

carolanitz · 2018-07-30T14:09:49Z

Sources/VLCActionSheet/VLCActionSheetCell.swift


-    static let identifier = "VLCActionSheetCell"
+    @objc static var identifier: String {
+        return String(describing: self)


That's interesting! Today I learned :) We should do that everywhere

carolanitz

Some comments are small some are bigger :) Overall the code looks very clean 👍 Did you or @Mikanbu test these changes with the chromecast actionsheet?
Also I noticed that the title header is supposed to be in bold font ^^

carolanitz · 2018-07-30T14:13:01Z

Sources/VLCSettingsController.m

+
+    specifierManager = [[VLCSettingsSpecifierManager alloc] initWithSpecifier:specifier settingsReader:self.settingsReader settingsStore:self.settingsStore];
+    actionSheet.delegate = specifierManager;
+    actionSheet.dataSource = specifierManager;


It should be enough to create the Actionsheet and specifierManager once. Right now you do it on every tab of the cell.

carolanitz · 2018-07-30T14:13:38Z

Sources/VLCSettingsController.m

+    actionSheet.delegate = specifierManager;
+    actionSheet.dataSource = specifierManager;
+
+    [actionSheet setActionWithClosure:^(id item) {


can we use something else than id here?

I don't think so because the closure is receiving bunch of different types as item. But even if we were able to type check item as something like long, InAppSettings doesn't provide a set___ method for all types

carolanitz · 2018-07-30T14:14:25Z

Sources/VLCSettingsController.m

+        NSDictionary *info = [NSDictionary dictionaryWithObject:item forKey:[specifier key]];
+        [[NSNotificationCenter defaultCenter] postNotificationName:kIASKAppSettingChanged
+                                                            object:[specifier key]
+                                                          userInfo:info];


do you need to fire the notification here? Is it not done in the setter of the settingsstore?

Wow, I didn't know that :D
It works without the 2 lines.

carolanitz · 2018-07-30T14:19:06Z

Sources/VLCSettingsTableViewCell.swift

-            selectionStyle = .default
        default:
-            assertionFailure("\(reuseIdentifier) has not been defined for VLCSettingsTableViewCell")
+            accessoryType = .none


Can we handle it explicitly for the known cases and keep the assertionFailure?

Yes! Don't know what I was thinking :p

carolanitz · 2018-07-30T14:20:34Z

Sources/VLCSettingsSpecifierManager.swift

+    }
+
+    var selectedIndex: IndexPath {
+        var index: Int


you can make that a let since it will definitely be set in the if else part

carolanitz · 2018-07-30T14:26:31Z

Sources/VLCSettingsSpecifierManager.swift

+                return
+        }
+
+        updateCollectionViewCellApparence(cell: oldCell, highlighted: false)


instead of highlighted does the cell maybe know that it's highlighted or selected itself? Maybe you can overwrite the setter if that's the case

carolanitz · 2018-07-30T14:31:20Z

Sources/VLCSettingsSpecifierManager.swift

+        }
+
+        let titles = specifier.multipleTitles()
+        cell.name.text = settingsReader.title(forStringId: titles?[indexPath.row] as? String)


can we add a check for indexPath.row < titles.count? Otherwise we crash here and maybe as well that the object is of type String otherwise we fail here silently

carolanitz · 2018-07-30T14:33:02Z

Sources/VLCSettingsSheetCell.swift

+ * VLCSettingSheetCell.swift
+ *
+ * Copyright © 2018 VLC authors and VideoLAN
+ * Copyright © 2018 Videolabs


I think you can remove the Videolabs copyright ;)

carolanitz · 2018-07-30T14:34:59Z

Sources/VLCSettingsController.m

+
+    [actionSheet setActionWithClosure:^(id item) {
+        [self.settingsStore setObject:item forKey:specifier.key];
+        [self.settingsStore synchronize];


Doesn't the self here lead to a retain cycle?

carolanitz · 2018-07-30T14:38:35Z

Sources/VLCSettingsSpecifierManager.swift

+    @objc init(specifier: IASKSpecifier, settingsReader: IASKSettingsReader, settingsStore: IASKSettingsStore) {
+        self.specifier = specifier
+        self.settingsReader = settingsReader
+        self.settingsStore = settingsStore


shouldn't there be a super.init() ?

Good catch :D

Mikanbu · 2018-07-31T08:27:49Z

Sources/VLCActionSheet/VLCActionSheetSectionHeader.swift

    let title: UILabel = {
        let title = UILabel()
-        title.font = UIFont.systemFont(ofSize: 13)
+        title.font = UIFont.boldSystemFont(ofSize: 13)


Is this change according to Figma?

Mikanbu · 2018-07-31T08:28:14Z

Sources/VLCActionSheet/VLCActionSheetCell.swift

        name.textColor = PresentationTheme.current.colors.cellTextColor
        name.font = UIFont.systemFont(ofSize: 15)
        name.translatesAutoresizingMaskIntoConstraints = false
+        name.setContentHuggingPriority(.defaultLow, for: .horizontal)


Do we need to set ContentHuggingPriority ?

This is to extend the name label all the way to the right so the checkmark can be at the rightmost edge. It can be moved to the subclass if it's breaking things.

Mikanbu · 2018-07-31T08:29:24Z

Sources/VLCActionSheet/VLCActionSheetCell.swift

    }

-    private func setupViews() {
+    func setupViews() {


I don't think this method should be internal.

can I ask you why?? It's currently being overriden by VLCSettingsActionSheetCell

I believe that it would be quite wrong to let other classes have the possibility to initialize the properties of VLCActionSheetCell.

I'm not saying that VLCActionSheetCell is perfect but I think classes should try to stay "self-contained".

For example, I think this would be nicer:

class TestCell: VLCActionSheetCell { override init(frame: CGRect) { super.init(frame: frame) // super.setupViews() is called in the super.init() setupViews() } required init?(coder aDecoder: NSCoder) { fatalError("init(coder:) has not been implemented") } private func setupViews() { stackView.removeArrangedSubview(icon) stackView.addArrangedSubview(//something\\) } }

Also, I'm sorry if I don't make any sense 😅

Gotcha! And it totally makes sense :D

Mikanbu · 2018-07-31T08:43:13Z

Sources/VLCSettingsSpecifierManager.swift

+    @objc init(settingsReader: IASKSettingsReader, settingsStore: IASKSettingsStore) {
+        super.init()
+        self.settingsReader = settingsReader
+        self.settingsStore = settingsStore


Shouldn't the properties be initialized before calling super.init()? Therefore not needing to implicitly unwrap the properties on top?

ah good catch. completely missed this :D

mkchoi212 · 2018-08-01T02:00:29Z

Just tested it with Chromecast and nothing seems to be broken @carolanitz

Btw, I deleted the "if only 1 renderer, automatically select it" to get this screenshot

mkchoi212 · 2018-08-10T15:56:38Z

🔔 ping!

carolanitz · 2018-08-13T13:50:29Z

Sources/VLCSettingsSpecifierManager.swift

+
+    func actionSheet(collectionView: UICollectionView, cellForItemAt indexPath: IndexPath) -> UICollectionViewCell {
+        guard let cell = collectionView.dequeueReusableCell(withReuseIdentifier: VLCSettingsSheetCell.identifier, for: indexPath) as? VLCSettingsSheetCell else {
+            fatalError("VLCSettingsSpecifierManager: VLCActionSheetDataSource: Unable to dequeue reusable cell")


doesn't dequeueReusableCell return nil when there is no cell to reuse ? and shouldn't in that case a new Cell be created instead of having a fatalError ?

carolanitz · 2018-08-13T13:52:30Z

@mkchoi212 looks fine to me just that one question regarding dequeueReusableCell :)

mkchoi212 · 2018-08-20T16:55:20Z

🔔 ping :D

carolanitz · 2018-08-20T19:01:34Z

sorry this time I saw something else instead of having fatalerrors which litterally crash the app we should probably return rather empty arrays and just have assertionfailures. The only time you should use fatalerror is when you corrupt data or get into an unrecoverable appstate where only a restart would be the solution. Other options are errormessages to the user

carolanitz · 2018-08-20T19:04:49Z

Sources/VLCSettingsSpecifierManager.swift

+
+    func actionSheet(collectionView: UICollectionView, cellForItemAt indexPath: IndexPath) -> UICollectionViewCell {
+        guard let cell = collectionView.dequeueReusableCell(withReuseIdentifier: VLCSettingsSheetCell.identifier, for: indexPath) as? VLCSettingsSheetCell else {
+            return UICollectionViewCell()


might make sense to still have an assertionfailure here because this should only happen when someone forgot to register the cellidentifier and the cellclass right ?

carolanitz · 2018-08-20T19:37:54Z

merged with 0bcf87a and following

mkchoi212 force-pushed the settings-action branch from 40b4f80 to be2d069 Compare July 23, 2018 06:16

mkchoi212 changed the title ~~Settings: Modal view~~ Settings: Actionsheet Jul 23, 2018

mkchoi212 force-pushed the settings-action branch 2 times, most recently from 9f55883 to a0b7312 Compare July 23, 2018 07:19

mkchoi212 commented Jul 23, 2018

View reviewed changes

mkchoi212 force-pushed the settings-action branch 3 times, most recently from e7a85d0 to b42bf75 Compare July 25, 2018 03:16

mkchoi212 changed the title ~~Settings: Actionsheet~~ [WIP] Settings: Actionsheet Jul 25, 2018

mkchoi212 force-pushed the settings-action branch from b42bf75 to a96e95b Compare July 25, 2018 06:46

mkchoi212 changed the title ~~[WIP] Settings: Actionsheet~~ Settings: Actionsheet Jul 25, 2018

mkchoi212 force-pushed the settings-action branch from a96e95b to a0d4510 Compare July 25, 2018 06:52

carolanitz reviewed Jul 30, 2018

View reviewed changes

carolanitz requested changes Jul 30, 2018

View reviewed changes

mkchoi212 force-pushed the settings-action branch from a0d4510 to 332f986 Compare July 31, 2018 07:42

Mikanbu reviewed Jul 31, 2018

View reviewed changes

mkchoi212 force-pushed the settings-action branch from 332f986 to 843a2fe Compare July 31, 2018 08:55

mkchoi212 force-pushed the settings-action branch from 843a2fe to 64450d8 Compare August 1, 2018 02:13

mkchoi212 added 2 commits August 2, 2018 13:43

Settings: Change cell accessory style

bbd22b6

UI: Create VLCSettingsSheetCell

af331da

mkchoi212 force-pushed the settings-action branch from 64450d8 to 73b6147 Compare August 2, 2018 04:43

carolanitz reviewed Aug 13, 2018

View reviewed changes

mkchoi212 added 2 commits August 14, 2018 17:15

Settings: Use custom action sheet to modify values

08c816f

VLCActionSheet: Bold header title

57fccfe

mkchoi212 force-pushed the settings-action branch from 73b6147 to 57fccfe Compare August 14, 2018 22:15

carolanitz reviewed Aug 20, 2018

View reviewed changes

carolanitz approved these changes Aug 20, 2018

View reviewed changes

carolanitz closed this Aug 20, 2018

mkchoi212 deleted the settings-action branch August 20, 2018 20:02

mkchoi212 restored the settings-action branch August 20, 2018 20:03

mkchoi212 deleted the settings-action branch August 20, 2018 20:03

mkchoi212 restored the settings-action branch August 20, 2018 20:03

mkchoi212 deleted the settings-action branch August 20, 2018 20:03

Conversation

mkchoi212 commented Jul 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Description

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carolanitz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkchoi212 Jul 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkchoi212 Jul 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkchoi212 commented Aug 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkchoi212 commented Jul 23, 2018 •

edited

Loading

mkchoi212 Jul 31, 2018 •

edited

Loading

mkchoi212 Jul 31, 2018 •

edited

Loading

mkchoi212 commented Aug 1, 2018 •

edited

Loading