Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Settings view (closes #268) #109

Closed
wants to merge 2 commits into from

Conversation

mkchoi212
Copy link
Collaborator

Checklist

  • I've run bundle exec fastlane test from the root directory to see all new and existing tests pass
  • I've followed the vlc-ios code style and run bundle exec fastlane lint to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Description

Issue reference https://code.videolan.org/videolan/vlc-ios/issues/268.

From looking at https://developer.apple.com/documentation/uikit/uitableviewheaderfooterview/1624912-textlabel, it seems as if using the default textLabel to customize the header view may be a bad idea when also adding a separator (subview).

Accessing the value in this property causes the view to create a default label for displaying a detail text string. If you are managing the content of the view yourself by adding subviews to the contentView property, you should not access this property.

Copy link
Collaborator

@dcordero dcordero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 🎩

@carolanitz
Copy link
Member

👍

@carolanitz
Copy link
Member

merged with b4f76c4 & 05c3252

@carolanitz carolanitz closed this Aug 13, 2018
@mkchoi212 mkchoi212 deleted the settings-fix branch August 13, 2018 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants