New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Settings view (closes #268) #109

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@mkchoi212
Collaborator

mkchoi212 commented Jul 31, 2018

Checklist

  • I've run bundle exec fastlane test from the root directory to see all new and existing tests pass
  • I've followed the vlc-ios code style and run bundle exec fastlane lint to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Description

Issue reference https://code.videolan.org/videolan/vlc-ios/issues/268.

From looking at https://developer.apple.com/documentation/uikit/uitableviewheaderfooterview/1624912-textlabel, it seems as if using the default textLabel to customize the header view may be a bad idea when also adding a separator (subview).

Accessing the value in this property causes the view to create a default label for displaying a detail text string. If you are managing the content of the view yourself by adding subviews to the contentView property, you should not access this property.

@mkchoi212 mkchoi212 force-pushed the mkchoi212:settings-fix branch from 41e9ffa to db46c1c Jul 31, 2018

@dcordero

Neat 🎩

@carolanitz

This comment has been minimized.

Member

carolanitz commented Aug 13, 2018

👍

@carolanitz

This comment has been minimized.

Member

carolanitz commented Aug 13, 2018

merged with b4f76c4 & 05c3252

@carolanitz carolanitz closed this Aug 13, 2018

@mkchoi212 mkchoi212 deleted the mkchoi212:settings-fix branch Aug 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment