Fix Settings view (closes #268) #109
Closed
Conversation
Neat |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Checklist
bundle exec fastlane test
from the root directory to see all new and existing tests passbundle exec fastlane lint
to ensure the code style is validDescription
Issue reference https://code.videolan.org/videolan/vlc-ios/issues/268.
From looking at https://developer.apple.com/documentation/uikit/uitableviewheaderfooterview/1624912-textlabel, it seems as if using the default
textLabel
to customize the header view may be a bad idea when also adding a separator (subview).