Fix Settings view (closes #268)

[mkchoi212]

Checklist

• I've run bundle exec fastlane test from the root directory to see all new and existing tests pass
• I've followed the vlc-ios code style and run bundle exec fastlane lint to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Description

Issue reference https://code.videolan.org/videolan/vlc-ios/issues/268.

From looking at https://developer.apple.com/documentation/uikit/uitableviewheaderfooterview/1624912-textlabel, it seems as if using the default textLabel to customize the header view may be a bad idea when also adding a separator (subview).

Accessing the value in this property causes the view to create a default label for displaying a detail text string. If you are managing the content of the view yourself by adding subviews to the contentView property, you should not access this property.

[dcordero]

Neat 🎩

[carolanitz]

👍

[carolanitz]

merged with b4f76c4 & 05c3252