Settings view

[mkchoi212]

Checklist

• I've run bundle exec fastlane test from the root directory to see all new and existing tests pass
• I've followed the vlc-ios code style and run bundle exec fastlane lint to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Description

Settings view has been updated to match the mockups on Figma (almost)

There are still couple of things that need to be fixed but thought I would open this PR to share with you guys what I have so far 😄

[Mikanbu]

I'm aware that this is a WIP so I'm just going to leave a single comment! 😄
What would you think about using [NSLayoutConstraint activateConstraints:@[];?

[mkchoi212]

I didn't know that was a thing! Definitely makes it look cleaner :D

[mkchoi212]

If you don't mind, please put more comments on stuff! I'm kinda stuck on most things anyways 🤦‍♂️

[Mikanbu]

Yes, and if we trust the documentation, it's even sometimes faster! 😄

[mkchoi212]

How do I go about adding a new string that needs to be localized??

[fkuehne]

You need to add constants and their plain text counter-part to the en.lproj's "Root.strings" within the Settings.bundle.

[mkchoi212]

Same thing here. Needs localization

[fkuehne]

See above :)

[Mikanbu]

Thanks for your work, you will find some small comments/thoughts in line~

[Mikanbu]

I think we can remove this bit of code since we don't support pre-iOS 6 anymore?

[fkuehne]

oh yes!

[Mikanbu]

I think we should consider using a macro at the top for the default values.
For example something like:
#define SETTINGS_HEADER_HEIGHT 64

We could also use a const for this if you prefer.

[fkuehne]

Yes, that's a good idea and matches what we have in other classes.

[Mikanbu]

Are you sure about the About ☜(゚ヮ゚☜) string the right localization identifier?

[carolanitz]

showAbout: as selector would be better :) The controller is not pushed

[Mikanbu]

What would you think about having a dynamic height?(mostly for accessibility reasons)
Like for example what @carolanitz did in bf01cc4

[fkuehne]

You need to add constants and their plain text counter-part to the en.lproj's "Root.strings" within the Settings.bundle.

[fkuehne]

See above :)

[fkuehne]

👍

[fkuehne]

Yes, that's a good idea and matches what we have in other classes.

[fkuehne]

Can we generalize that font configuration similar to the way we handle colors in a global sense?

[fkuehne]

oh yes!

[mkchoi212]

With 672bda1, the privacy cell is in the same section as the theme cell as shown in the mockup!

[mkchoi212]

Little hack to ensure minimum height in UITableViewCellStyleSubtitle

[carolanitz]

no hacks, please. If you want to ensure the correct height that leaves enough room you overwrite a cells systemLayoutSizeFittingSize or something like that. There are a bunch of articles on how to achieve this. Your implementation will not leave enough room when you have large text which is what you wanted if I understand the automatic dimension correctly. This will also make the MinimumSettingsrowheight obsolete

[mkchoi212]

Final view has...

• Section header with separator (Kind of iffy about how it looks)
• Subtitle style for applicable tableview cells
• Cell separator turned off
• Minimum cell height of 64px
• New labeling on headers
• About button on top left corner

[Mikanbu]

Sorry, small nitpicking again 😄
When in dark mode, the thumbTintColor of the switches should be changed as well like:
https://gyazo.com/ea524b9883585fb97d504c5de34705be

[carolanitz]

Looks already really good. There is a bunch of code that should probably be pulled out of the settingscontroller class and possibly even the file though :)

[carolanitz]

do we really need all of these imports ?

[carolanitz]

showAbout: as selector would be better :) The controller is not pushed

[carolanitz]

do we need the IBAction here and the sender? I mean I don't care really but It's always a sign that something is connected over Interface Builder which is not the case here

[mkchoi212]

Don't know what I was thinking :p Rookie mistake!

[carolanitz]

this should be presented now since it's not part of the Tableview

[carolanitz]

I think we also need that actually in the local network screen

[carolanitz]

^ This really needs to be consistent throughout the app. Can we adjust this in the local network screen as well as part of this PR but in a separate commit?

[carolanitz]

can go away if you set the rowheight property up top

[mkchoi212]

I tried what you suggested but I think this is necessary to override the heightForRowAtIndexPath already declared in its parent class IASKSettingsViewController

[carolanitz]

This will "break" and by that I mean the separator will be too short when you rotate the view since you set a static frame

[carolanitz]

Can we write cell subclasses for this and not cram everything in this method and viewcontroller? Also magic numbers. By having subclass in an extra file we should also be able to remove some of the above imports I reckon, which will make the entire thing more readable

[mkchoi212]

VLCSettingsTableViewCell.h/m has been created!

[carolanitz]

space before the *

[mkchoi212]

duh 😄

[carolanitz]

no hacks, please. If you want to ensure the correct height that leaves enough room you overwrite a cells systemLayoutSizeFittingSize or something like that. There are a bunch of articles on how to achieve this. Your implementation will not leave enough room when you have large text which is what you wanted if I understand the automatic dimension correctly. This will also make the MinimumSettingsrowheight obsolete

[mkchoi212]

This was required to silence auto layout warnings. See https://stackoverflow.com/a/35053234/4064189

[carolanitz]

could you try giving the constraints a priority of 999. This allows them to break temporarily while the height or width is 0

[carolanitz]

why is this needed?

[mkchoi212]

whoops!

[carolanitz]

can we write new files in swift?

[carolanitz]

also prepare for reuse is missing

[carolanitz]

^ This really needs to be consistent throughout the app. Can we adjust this in the local network screen as well as part of this PR but in a separate commit?

[carolanitz]

^

[carolanitz]

could you try giving the constraints a priority of 999. This allows them to break temporarily while the height or width is 0

[carolanitz]

separators usually have a height of 1 or 0.5 even why the 2?

[mkchoi212]

Figma mockups say 2 but changing it to 1 ended up looking a lot better

[carolanitz]

this font shouldn't be defined here

[carolanitz]

switch over the specifier.type

[carolanitz]

value is too vague can we have a variable instead and a couple of checks that the object that you try to get out of there is really the type that you expect?

[mkchoi212]

All type checks are done by configureForSpecifier for different types of cells with functions from InAppSettingsKit :D

[carolanitz]

could we have the entire cell be a touch target and not the switch itself?

[carolanitz]

This looks already a lot better!!
I checked the PR out and constraints seem to break. I don't think you really need to have a designated xib for that since you just have the two labels in there. You can use the UITableviewCells ones for this. The subclass itself definitely makes sense. I'm not sure if Louis really wants to deviate from the standard cellheight here but if so we will find a simpler solution than creating a xib with a bunch of constraints to accomodate that and that can go into a separate PR as well

[carolanitz]

can we move the self.tableview.heightForRow = UIDimensionAutomatic here as well?

[carolanitz]

IASKSpecifier *specifier = [self.settingsReader specifierForIndexPath:indexPath];
Bool cellHasSlider = [specifier.type isEqual: kIASKPSSliderSpecifier];
return cellHasSlider ? nil : indexPath;

would that be more obvious ? We can leave it as is, just as a suggestion :)
Btw seeing the kIASKPSToggleSwitchSpecifier a few lines down as well I wonder if that shouldn't be included here

[mkchoi212]

The kIASKPSToggleSwitchSpecifier is to allow users to toggle the switch by pressing the cell. Is this not what you meant by have the entire cell be a touch target and not the switch itself? 🤔

[carolanitz]

oh yeah you're right if we include it here the event wouldn't go through. can we just make sure that it doesn't get the grey selectionstate when you select the cell?

[carolanitz]

can we not use the Textlabel and detaillabel from the UItableViewCell ?

[carolanitz]

that would happen automatically if you use the standard elements

[carolanitz]

can be removed if the separatorStyle is none

[carolanitz]

merged with ff9342f and following

[mkchoi212]

@ALL thanks for all the comments guys! this was a big one :D