New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modally present about view #84

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@mkchoi212
Collaborator

mkchoi212 commented Jun 27, 2018

Checklist

  • I've run bundle exec fastlane test from the root directory to see all new and existing tests pass
  • I've followed the vlc-ios code style and run bundle exec fastlane lint to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Description

About view in settings tab is now displayed modally instead of being pushed.

simulator screen shot - iphone x - 2018-06-27 at 14 57 59
simulator screen shot - iphone x - 2018-06-27 at 14 57 55

@mkchoi212 mkchoi212 changed the title from Modally present about view to [WIP] Modally present about view Jun 27, 2018

@mkchoi212

This comment has been minimized.

Collaborator

mkchoi212 commented Jun 27, 2018

Need to update the UI tests!

@mkchoi212 mkchoi212 force-pushed the mkchoi212:show-about branch to dbe85bb Jun 28, 2018

@mkchoi212 mkchoi212 changed the title from [WIP] Modally present about view to Modally present about view Jun 28, 2018

@carolanitz

This comment has been minimized.

Member

carolanitz commented Jul 2, 2018

can you remove the about cell in the settingsViewController as well? Rest looks good to me

@mkchoi212

This comment has been minimized.

Collaborator

mkchoi212 commented Jul 2, 2018

🎉 for deleting things

@carolanitz

This comment has been minimized.

Member

carolanitz commented Jul 9, 2018

merged with 211a741

@carolanitz carolanitz closed this Jul 9, 2018

@mkchoi212 mkchoi212 deleted the mkchoi212:show-about branch Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment