Settings: tableview section separator #91
Conversation
mkchoi212
force-pushed
the
settings-header
branch
2 times, most recently
from
92876a9
to
c9a6d67
Compare
| public let tableHeader: UIFont | ||
|
|
||
| public init(tableHeader: UIFont) { | ||
| self.tableHeader = tableHeader |
There was a problem hiding this comment.
Is there a specific reason why we would want this class to be public?
There was a problem hiding this comment.
Hmmm I guess it's unnecessary
| @objc static let identifier = String(describing: VLCSettingsTableHeaderView.self) | ||
| @objc var headerLabel: UILabel! | ||
| @objc var separator: UIView! | ||
|
|
There was a problem hiding this comment.
What do you think about initializing them directly here?
For example:
@objc var separator: UIView = {
let separator = UIView()
separator.backgroundColor = PresentationTheme.current.colors.separatorColor
separator.translatesAutoresizingMaskIntoConstraints = false
return separator
}()
This will make the init clearer by only having the addSubView() calls and the constraints stuff.
There was a problem hiding this comment.
Good point. I always forget you can do this :D
| override init(reuseIdentifier: String?) { | ||
| super.init(reuseIdentifier: reuseIdentifier) | ||
|
|
||
| constraints.forEach { $0.priority = UILayoutPriority(rawValue: 999) } |
There was a problem hiding this comment.
I think it's better if we use .required - 1 here.
mkchoi212
force-pushed
the
settings-header
branch
from
c9a6d67
to
c060f4b
Compare
| import UIKit | ||
|
|
||
| class VLCSettingsTableHeaderView: UITableViewHeaderFooterView { | ||
| let headerHeight: CGFloat = 1.0 |
There was a problem hiding this comment.
Do we need to expose this outside of this class? If not we should consider "privatizing" it 😄
mkchoi212
force-pushed
the
settings-header
branch
2 times, most recently
from
81024f3
to
38008ad
Compare
|
|
||
| let tableHeader: UIFont | ||
|
|
||
| init(tableHeader: UIFont) { |
| - (NSString *)tableView:(UITableView *)tableView titleForHeaderInSection:(NSInteger)section | ||
| { | ||
| return nil; | ||
| } |
There was a problem hiding this comment.
This can be deleted it will fall back to viewForHeaderInSection
There was a problem hiding this comment.
Hmmm without it, the header titles come out capitalized. I think this is because InAppSettings has a default titleForHeaderInSection
|
|
||
| import UIKit | ||
|
|
||
| class VLCSettingsTableHeaderView: UITableViewHeaderFooterView { |
There was a problem hiding this comment.
Could you adjust this to the new class VLCSectionTableHeaderView?
mkchoi212
force-pushed
the
settings-header
branch
from
38008ad
to
e936967
Compare
|
merged with 7ea7027 and following |
Checklist
bundle exec fastlane testfrom the root directory to see all new and existing tests passbundle exec fastlane lintto ensure the code style is validDescription
Added a separator in-between tableview sections.