videolan / vlckit

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup testing environment #11

Closed

mkchoi212 wants to merge 2 commits into videolan:master from mkchoi212:VLCMedia-tests

Contributor

mkchoi212 commented May 14, 2018 •

edited

Tests for VLCTime.m have been added.

Changes to project.pbxproj have been made to make the tests compile but may need some cleanup in the future.

mkchoi212 changed the title ~~Add tests for VLCTime.m~~ Add tests for VLCTime

carolanitz reviewed

Member

carolanitz left a comment

Smaller pullrequests will be a lot better. I simply couldn't check if you covered all the methods and all cases of it . Make one PR with all tests for one function :) Otherwise this will become a huuuge Pullrequest and I will miss way too much

MobileVLCKit.xcodeproj/project.pbxproj Outdated

  
        				GCC_C_LANGUAGE_STANDARD = gnu11;

        				GCC_OPTIMIZATION_LEVEL = s;

        				GCC_PRECOMPILE_PREFIX_HEADER = YES;

        				GCC_PREFIX_HEADER = Headers/PCH/MobilePrefix.pch;

        				GCC_SYMBOLS_PRIVATE_EXTERN = YES;

        				HEADER_SEARCH_PATHS = "$(SRCROOT)/libvlc/vlc/include";

        				INSTALL_PATH = /usr/local/lib;

        				IPHONEOS_DEPLOYMENT_TARGET = 7.0;

        				IPHONEOS_DEPLOYMENT_TARGET = 8.0;

carolanitz May 15, 2018
Member

why are you changing the deployment target ?

Tests/iOS/VLCMediaTests/VLCMediaTests.xcodeproj/project.pbxproj Outdated

  
        				CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;

        				CLANG_WARN_DOCUMENTATION_COMMENTS = YES;

        				CLANG_WARN_EMPTY_BODY = YES;

        				CLANG_WARN_ENUM_CONVERSION = YES;

        				CLANG_WARN_INFINITE_RECURSION = YES;

        				CLANG_WARN_INT_CONVERSION = YES;

        				CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;

        				CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;

carolanitz May 15, 2018
Member

Did this get added because you pressed the update xcode settings button ?

mkchoi212 May 15, 2018
Author Contributor

Yes I think so. Should this be removed?

carolanitz May 16, 2018
Member

no that's fine from my side. I was just wondering

Tests/iOS/VLCMediaTests/VLCMediaTestsTests/VLCMediaTestsTests.m Outdated

carolanitz May 15, 2018
Member

👍

Tests/iOS/VLCMediaTests/VLCMediaTestsTests/VLCTimeTest.swift Outdated

  
         *****************************************************************************

         * Copyright (C) 2007 Pierre d'Herbemont

         * Copyright (C) 2013, 2017 Felix Paul Kühne

         * Copyright (C) 2007, 2013 VLC authors and VideoLAN

carolanitz May 15, 2018
Member

Pierre and Felix didin't write this class ;)

Tests/iOS/VLCMediaTests/VLCMediaTestsTests/VLCTimeTest.swift Outdated

  
            func testInitializers() {

                let testTime: Int32 = 100000

                let expected = TimeResult(value: NSNumber(value: testTime), string: "01:40", verboseString: "1 minutes 40 seconds", minuteString: "1", intValue: testTime)

carolanitz May 15, 2018
Member

we should have minute here

Tests/iOS/VLCMediaTests/VLCMediaTestsTests/VLCTimeTest.swift Outdated

  
                let expected = TimeResult(value: nil, string: "--:--", verboseString: "", minuteString: "", intValue: 0)

                expected.assertEqual(nullTime)

            }

carolanitz May 15, 2018
Member

you missed testTimeWithNumber, testtimeWithInt and right ?

Tests/iOS/VLCMediaTests/VLCMediaTestsTests/VLCTimeTest.swift Outdated

  
                expected.assertEqual(nullTime)

            }

            func testInitializers() {

carolanitz May 15, 2018
Member

Shouldn't be testInitWithNumber ?

mkchoi212 May 15, 2018
Author Contributor

I combined tests for initWithNumber and initwithInt into tesIntializers to make things less verbose. Should they be separated?

carolanitz May 16, 2018
Member

yes. One test to test one thing or one method

Tests/iOS/VLCMediaTests/VLCMediaTestsTests/VLCTimeTest.swift Outdated

  
                expected.assertEqual(timeFromInt)

                expected.assertEqual(timeFromNumber)

            }

carolanitz May 15, 2018
Member

testInitWithInt is missing

mkchoi212 force-pushed the mkchoi212:VLCMedia-tests branch from 83a9f17 to ed0518b

Contributor Author

mkchoi212 commented May 15, 2018 •

edited

I split up the big commit into smaller chunks so it's easier to see!
Also, more tests for time -> string has been added.

mkchoi212 force-pushed the mkchoi212:VLCMedia-tests branch 4 times, most recently from 68d92b3 to d3415d3


          Tests: Setup iOS tests in MobileVLCKit

mkchoi212 force-pushed the mkchoi212:VLCMedia-tests branch 2 times, most recently from affd6fd to 3507780

mkchoi212 changed the title ~~Add tests for VLCTime~~ Setup testing environment

carolanitz approved these changes


          Tests: Add initial test stub

26b1bbe

Member

carolanitz commented May 23, 2018

this has been merged with e8ba7c2 and c2044e8

carolanitz closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment