Setup testing environment #11
Conversation
| GCC_C_LANGUAGE_STANDARD = gnu11; | ||
| GCC_OPTIMIZATION_LEVEL = s; | ||
| GCC_PRECOMPILE_PREFIX_HEADER = YES; | ||
| GCC_PREFIX_HEADER = Headers/PCH/MobilePrefix.pch; | ||
| GCC_SYMBOLS_PRIVATE_EXTERN = YES; | ||
| HEADER_SEARCH_PATHS = "$(SRCROOT)/libvlc/vlc/include"; | ||
| INSTALL_PATH = /usr/local/lib; | ||
| IPHONEOS_DEPLOYMENT_TARGET = 7.0; | ||
| IPHONEOS_DEPLOYMENT_TARGET = 8.0; |
There was a problem hiding this comment.
why are you changing the deployment target ?
| CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR; | ||
| CLANG_WARN_DOCUMENTATION_COMMENTS = YES; | ||
| CLANG_WARN_EMPTY_BODY = YES; | ||
| CLANG_WARN_ENUM_CONVERSION = YES; | ||
| CLANG_WARN_INFINITE_RECURSION = YES; | ||
| CLANG_WARN_INT_CONVERSION = YES; | ||
| CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES; | ||
| CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES; |
There was a problem hiding this comment.
Did this get added because you pressed the update xcode settings button ?
There was a problem hiding this comment.
Yes I think so. Should this be removed?
There was a problem hiding this comment.
no that's fine from my side. I was just wondering
| }]; | ||
| } | ||
|
|
||
| @end |
| ***************************************************************************** | ||
| * Copyright (C) 2007 Pierre d'Herbemont | ||
| * Copyright (C) 2013, 2017 Felix Paul Kühne | ||
| * Copyright (C) 2007, 2013 VLC authors and VideoLAN |
There was a problem hiding this comment.
Pierre and Felix didin't write this class ;)
|
|
||
| func testInitializers() { | ||
| let testTime: Int32 = 100000 | ||
| let expected = TimeResult(value: NSNumber(value: testTime), string: "01:40", verboseString: "1 minutes 40 seconds", minuteString: "1", intValue: testTime) |
| let expected = TimeResult(value: nil, string: "--:--", verboseString: "", minuteString: "", intValue: 0) | ||
| expected.assertEqual(nullTime) | ||
| } | ||
|
|
There was a problem hiding this comment.
you missed testTimeWithNumber, testtimeWithInt and right ?
| expected.assertEqual(nullTime) | ||
| } | ||
|
|
||
| func testInitializers() { |
There was a problem hiding this comment.
Shouldn't be testInitWithNumber ?
There was a problem hiding this comment.
I combined tests for initWithNumber and initwithInt into tesIntializers to make things less verbose. Should they be separated?
There was a problem hiding this comment.
yes. One test to test one thing or one method
| expected.assertEqual(timeFromInt) | ||
| expected.assertEqual(timeFromNumber) | ||
| } | ||
|
|
|
I split up the big commit into smaller chunks so it's easier to see! |
mkchoi212
force-pushed
the
VLCMedia-tests
branch
4 times, most recently
from
68d92b3
to
d3415d3
Compare
mkchoi212
force-pushed
the
VLCMedia-tests
branch
2 times, most recently
from
affd6fd
to
3507780
Compare
Tests for
VLCTime.mhave been added.Changes to
project.pbxprojhave been made to make the tests compile but may need some cleanup in the future.