New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage #16

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@mkchoi212
Contributor

mkchoi212 commented May 28, 2018

Code coverage implementation on CircleCI along with pretty output with xcpretty during testing has been implemented.

@mkchoi212 mkchoi212 force-pushed the mkchoi212:code-cov branch from 617ad55 to 5631dba May 28, 2018

@mkchoi212 mkchoi212 changed the title from [WIP] Code coverage to Code coverage May 29, 2018

@mkchoi212 mkchoi212 force-pushed the mkchoi212:code-cov branch 4 times, most recently from 87393c1 to 5b6860a May 29, 2018

@mkchoi212

This comment has been minimized.

Contributor

mkchoi212 commented May 29, 2018

Dummy CircleCI build with some testing code passed 🎉

You can checkout the static html generated by slather here and the CircleCI build here

mkchoi212 added some commits May 30, 2018

Add Gemfile
xcpretty is used to make xcodebuild test logs more readable

@mkchoi212 mkchoi212 force-pushed the mkchoi212:code-cov branch 3 times, most recently from b0b702c to dc3c7e8 May 30, 2018

@mkchoi212 mkchoi212 force-pushed the mkchoi212:code-cov branch from dc3c7e8 to 25e3739 May 30, 2018

@mkchoi212

This comment has been minimized.

Contributor

mkchoi212 commented May 30, 2018

Gave up on slather because it had some major bugs that need fixing. And Caro brought up a good point about trying to limit the number of dependencies.

So instead of slather, Apple's xccov is being used. The generated report is rather plain but as services like codecov.io start adopting the new format, I think we should look into using their services for making the reports look more comprehensible.

Here's a dummy CircleCI build with some test code in it.

@mkchoi212 mkchoi212 referenced this pull request Jun 5, 2018

Closed

VLCKit (macOS) Tests #17

@carolanitz

looks good to me

- run:
name: Generate Coverage Reports
command: |
rake codecov:ios

This comment has been minimized.

@carolanitz

carolanitz Jun 6, 2018

Member

👍 1:

@carolanitz

This comment has been minimized.

Member

carolanitz commented Jun 6, 2018

merged with 53dfdb4

@carolanitz carolanitz closed this Jun 6, 2018

@mkchoi212 mkchoi212 deleted the mkchoi212:code-cov branch Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment