Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage #16

Closed
wants to merge 4 commits into from
Closed

Code coverage #16

wants to merge 4 commits into from

Conversation

mkchoi212
Copy link
Contributor

@mkchoi212 mkchoi212 commented May 28, 2018

Code coverage implementation on CircleCI along with pretty output with xcpretty during testing has been implemented.

@mkchoi212 mkchoi212 changed the title [WIP] Code coverage Code coverage May 29, 2018
@mkchoi212 mkchoi212 force-pushed the code-cov branch 4 times, most recently from 87393c1 to 5b6860a Compare May 29, 2018 16:20
@mkchoi212
Copy link
Contributor Author

Dummy CircleCI build with some testing code passed 🎉

You can checkout the static html generated by slather here and the CircleCI build here

xcpretty is used to make xcodebuild test logs more readable
@mkchoi212 mkchoi212 force-pushed the code-cov branch 3 times, most recently from b0b702c to dc3c7e8 Compare May 30, 2018 15:12
@mkchoi212
Copy link
Contributor Author

Gave up on slather because it had some major bugs that need fixing. And Caro brought up a good point about trying to limit the number of dependencies.

So instead of slather, Apple's xccov is being used. The generated report is rather plain but as services like codecov.io start adopting the new format, I think we should look into using their services for making the reports look more comprehensible.

Here's a dummy CircleCI build with some test code in it.

@mkchoi212 mkchoi212 mentioned this pull request Jun 5, 2018
Copy link
Member

@carolanitz carolanitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

- run:
name: Generate Coverage Reports
command: |
rake codecov:ios
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 1:

@carolanitz
Copy link
Member

merged with 53dfdb4

@carolanitz carolanitz closed this Jun 6, 2018
@mkchoi212 mkchoi212 deleted the code-cov branch June 7, 2018 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants