VLCKit (macOS) Tests #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkchoi212
commented
Jun 7, 2018
| @@ -19,13 +19,14 @@ jobs: | |||
| paths: | |||
| - .bundle | |||
| - restore_cache: | |||
| key: libvlc-{{ checksum "compileAndBuildVLCKit.sh" }} | |||
| key: libvlc-v2-{{ checksum "compileAndBuildVLCKit.sh" }} | |||
There was a problem hiding this comment.
Cache key has been updated to account for the new macOS build
Closed
fkuehne
approved these changes
Jun 7, 2018
|
@fkuehne thank you 😊 |
carolanitz
reviewed
Jun 9, 2018
| 41657C232059D49200AB915B /* VLCRendererDiscoverer.h in Headers */ = {isa = PBXBuildFile; fileRef = 41657C212059D49200AB915B /* VLCRendererDiscoverer.h */; settings = {ATTRIBUTES = (Public, ); }; }; | ||
| 41657C242059D49200AB915B /* VLCRendererItem.h in Headers */ = {isa = PBXBuildFile; fileRef = 41657C222059D49200AB915B /* VLCRendererItem.h */; settings = {ATTRIBUTES = (Public, ); }; }; | ||
| 41657C232059D49200AB915B /* VLCRendererDiscoverer.h in Headers */ = {isa = PBXBuildFile; fileRef = 41657C212059D49200AB915B /* VLCRendererDiscoverer.h */; }; | ||
| 41657C242059D49200AB915B /* VLCRendererItem.h in Headers */ = {isa = PBXBuildFile; fileRef = 41657C222059D49200AB915B /* VLCRendererItem.h */; }; |
There was a problem hiding this comment.
does this mean the headers are not exposed anymore?
There was a problem hiding this comment.
They weren't being used anywhere in the project and were producing warnings because of it. They're still exposed in the project scope. Do they need to be public?
There was a problem hiding this comment.
yes, I just tried it out and double checked. It doesn't seem to make a difference
There was a problem hiding this comment.
If I remember correctly, you have to clean the build folder to apply the changes
|
Merged with 42a73a9 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR needs to be rebased once #16 is merged.
In this PR,
Rakefile.circle.ymlhas been updated