Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VLCKit (macOS) Tests #17

Closed
wants to merge 4 commits into from
Closed

VLCKit (macOS) Tests #17

wants to merge 4 commits into from

Conversation

@mkchoi212
Copy link
Contributor

@mkchoi212 mkchoi212 commented Jun 5, 2018

The following PR needs to be rebased once #16 is merged.

In this PR,

  • Test scheme for VLCKit has been created
  • build / test/ code coverage tasks have been added to the Rakefile
  • .circle.yml has been updated
@mkchoi212 mkchoi212 force-pushed the mkchoi212:setup-macos branch from 0a20483 to 073b956 Jun 5, 2018
@mkchoi212 mkchoi212 force-pushed the mkchoi212:setup-macos branch from 2b21598 to 21075e1 Jun 7, 2018
@mkchoi212 mkchoi212 force-pushed the mkchoi212:setup-macos branch from 21075e1 to 88fc250 Jun 7, 2018
@@ -19,13 +19,14 @@ jobs:
paths:
- .bundle
- restore_cache:
key: libvlc-{{ checksum "compileAndBuildVLCKit.sh" }}
key: libvlc-v2-{{ checksum "compileAndBuildVLCKit.sh" }}

This comment has been minimized.

@mkchoi212

mkchoi212 Jun 7, 2018
Author Contributor

Cache key has been updated to account for the new macOS build

@mkchoi212 mkchoi212 mentioned this pull request Jun 7, 2018
@fkuehne fkuehne self-requested a review Jun 7, 2018
@fkuehne
fkuehne approved these changes Jun 7, 2018
Copy link
Contributor

@fkuehne fkuehne left a comment

This looks good to me. Nice work!

@fkuehne fkuehne requested a review from carolanitz Jun 7, 2018
@mkchoi212
Copy link
Contributor Author

@mkchoi212 mkchoi212 commented Jun 8, 2018

@fkuehne thank you 😊

41657C232059D49200AB915B /* VLCRendererDiscoverer.h in Headers */ = {isa = PBXBuildFile; fileRef = 41657C212059D49200AB915B /* VLCRendererDiscoverer.h */; settings = {ATTRIBUTES = (Public, ); }; };
41657C242059D49200AB915B /* VLCRendererItem.h in Headers */ = {isa = PBXBuildFile; fileRef = 41657C222059D49200AB915B /* VLCRendererItem.h */; settings = {ATTRIBUTES = (Public, ); }; };
41657C232059D49200AB915B /* VLCRendererDiscoverer.h in Headers */ = {isa = PBXBuildFile; fileRef = 41657C212059D49200AB915B /* VLCRendererDiscoverer.h */; };
41657C242059D49200AB915B /* VLCRendererItem.h in Headers */ = {isa = PBXBuildFile; fileRef = 41657C222059D49200AB915B /* VLCRendererItem.h */; };

This comment has been minimized.

@carolanitz

carolanitz Jun 9, 2018
Member

does this mean the headers are not exposed anymore?

This comment has been minimized.

@mkchoi212

mkchoi212 Jun 11, 2018
Author Contributor

They weren't being used anywhere in the project and were producing warnings because of it. They're still exposed in the project scope. Do they need to be public?

This comment has been minimized.

@carolanitz

carolanitz Jun 14, 2018
Member

yes, I just tried it out and double checked. It doesn't seem to make a difference

This comment has been minimized.

@mkchoi212

mkchoi212 Jun 14, 2018
Author Contributor

If I remember correctly, you have to clean the build folder to apply the changes

@mkchoi212
Copy link
Contributor Author

@mkchoi212 mkchoi212 commented Jun 14, 2018

Merged with 42a73a9 🎉

@mkchoi212 mkchoi212 closed this Jun 14, 2018
@mkchoi212 mkchoi212 deleted the mkchoi212:setup-macos branch Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants