Tests: Add video samples

[mkchoi212]

4 sample videos have been downloaded and added.
Each video is about 3-5 seconds for the total size of 1.5 MB.

All videos have been downloaded from https://vimeo.com/user32335610 and are under the Creative Commons Public Domain Dedication license.

After downloading the clips, I shortened the videos and changed the file formats to diversify the sample.

[fkuehne]

Is it possible to store those videos online (we can provide storage space) and download them on-the-fly so we don't need to add so much binary data to the git?

[mkchoi212]

Good idea. If you could upload them to a server and provide me a link to them, that would be great!

[mkchoi212]

These links must be updated :D

[carolanitz]

if we upload it somewhere we have the same issues as in the mainrepo which is tests intermittedly failing because of slow connection or failing connection and if the tests are not reliable they're useless

[fkuehne]

Then we should have a git submodule for the files. Adding 6MB of binary blobs to the git just for testing will increase download time and used disk space for everyone, so it would be nicer to optionalize this.

[carolanitz]

Can we look into best practices for this usecase? We're not the only ones who deal with this problem so i'd like to know how other projects handle this case

[jbkempf]

Git-LFS is an option, but a pain to synchronize between repos.

The other is a local cache from distant files, like the contrib tarballs (SHA-512) and is probably the simplest.

[carolanitz]

Git-LFS is for large files, we're talking 1,5 MB here and isn't absolutely common to check in files for testing into a repo ?

[carolanitz]

btw don't get me wrong, this is absolutely a valid point that we might unnecessarily enlarge our repository here. I could've sworn though that checking test data into your repository is common practice so I didn't even second guess it.

[mkchoi212]

These links will be replaced by links for code.v.o once available

[carolanitz]

could you rebase this on master ? or does circleci failing because of something else ?

[mkchoi212]

The PR for TestAssets hasn’t been merged yet :(

I’ll ping thresh

[mkchoi212]

From Twitter, it seems like loading the videos from the test bundle after being downloaded is the best way to go; which is how this PR is setup.

Pros are

• Tests can't start if the assets can't be downloaded from code.v.o/TestAssets
  • This is good because if we don't load the videos from the bundle, the tests will start and fail with messages like "can't open file x"
• Buying into Xcode's infra

Cons are

• Minor complexity during initial test run
• Additional files added to .pbxproj

[carolanitz]

merged with commit aa98dd3 &&
commit 1be28e1 &&
commit 458b355