VLCLibrary: debugLogging status (closes #186) #30
Conversation
Sources/VLCLibrary.m
Outdated
| VKLog(@"Invalid debugLoggingLevel of %d provided", debugLoggingLevel); | ||
| VKLog(@"Please provide a valid debugLoggingLevel between 0 and 4"); | ||
| VKLog(@"Defaulting debugLoggingLevel to 4 (just errors)"); | ||
| _debugLoggingLevel = 4; |
There was a problem hiding this comment.
Decided to set a default value for the logging level because I think an invalid debug logging level isn't worth causing a crash.
There was a problem hiding this comment.
The scale is the other way around - 0 is just errors, whereas 4 is "everything VLC ever wanted to tell you about anything". So the default should be 0.
However, there is something wrong if there is a crash when the user provides 5. Are you sure that this is happening?
There was a problem hiding this comment.
Gotcha! Also, it doesn't crash. What I meant was that I initially thought about doing fatalError("Invalid debugging level x") but just decided to warn the user about it.
There was a problem hiding this comment.
What do you think about just capping the value between 0 and 4 meaning <0 to 0 >4 to 4 and if it's outside those bounds log the message ?
mkchoi212
force-pushed
the
lib-test
branch
2 times, most recently
from
4e1ed03 to
3aace59
Compare
Sources/VLCLibrary.m
Outdated
|
|
||
| - (void)setDebugLoggingLevel:(int)debugLoggingLevel | ||
| { | ||
| if (debugLoggingLevel < 0 && debugLoggingLevel > 4) { |
There was a problem hiding this comment.
@carolanitz something like this?? I’m mildly confused :D
mkchoi212
force-pushed
the
lib-test
branch
2 times, most recently
from
ba827f3 to
2a1db09
Compare
fkuehne
left a comment
fkuehne
left a comment
There was a problem hiding this comment.
One nit-pick, rest looks good now! :)
Headers/Public/VLCLibrary.h
Outdated
| * Currently, the framework does not support multiple instances of VLCLibrary. Furthermore, you cannot destroy any | ||
| * instiantiation of VLCLibrary, as previously noted, this is done automatically by the dynamic link loader. | ||
| * Currently, the framework __does not__ support multiple instances of VLCLibrary. | ||
| * Furthermore, you __cannot__ destroy any instance of VLCLibrary; this is done automatically by the dynamic link loader. |
There was a problem hiding this comment.
I'm not sure if this underling syntax is permitted in doxygen. Can you verify this?
There was a problem hiding this comment.
Ah I had no idea this was run through doxygen. And turns out, doxygen only supports __ syntax for markdown.
|
ping 🔔 |
|
merged |
3 participants
Fixes the bugs
debugLoggingStatuscan not be setdebugLoggingLevelcan exceed the set range of 0-4