Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upVLCLibrary: debugLogging status (closes #186) #30
Conversation
| VKLog(@"Invalid debugLoggingLevel of %d provided", debugLoggingLevel); | ||
| VKLog(@"Please provide a valid debugLoggingLevel between 0 and 4"); | ||
| VKLog(@"Defaulting debugLoggingLevel to 4 (just errors)"); | ||
| _debugLoggingLevel = 4; |
This comment has been minimized.
This comment has been minimized.
mkchoi212
Jul 20, 2018
•
Contributor
Decided to set a default value for the logging level because I think an invalid debug logging level isn't worth causing a crash.
This comment has been minimized.
This comment has been minimized.
fkuehne
Jul 20, 2018
Contributor
The scale is the other way around - 0 is just errors, whereas 4 is "everything VLC ever wanted to tell you about anything". So the default should be 0.
However, there is something wrong if there is a crash when the user provides 5. Are you sure that this is happening?
This comment has been minimized.
This comment has been minimized.
mkchoi212
Jul 20, 2018
Contributor
Gotcha! Also, it doesn't crash. What I meant was that I initially thought about doing fatalError("Invalid debugging level x") but just decided to warn the user about it.
This comment has been minimized.
This comment has been minimized.
carolanitz
Jul 20, 2018
Member
What do you think about just capping the value between 0 and 4 meaning <0 to 0 >4 to 4 and if it's outside those bounds log the message ?
mkchoi212
force-pushed the
mkchoi212:lib-test
branch
2 times, most recently
from
4e1ed03
to
3aace59
Jul 23, 2018
| if (debugLogging) { | ||
| libvlc_log_set(_instance, HandleMessage, (__bridge void *)(self)); | ||
| } else { | ||
| libvlc_log_unset(_instance); | ||
| } | ||
| } | ||
| - (void)setDebugLoggingLevel:(int)debugLoggingLevel | ||
| { | ||
| if (debugLoggingLevel < 0 && debugLoggingLevel > 4) { |
This comment has been minimized.
This comment has been minimized.
mkchoi212
force-pushed the
mkchoi212:lib-test
branch
2 times, most recently
from
ba827f3
to
2a1db09
Jul 26, 2018
| * Currently, the framework does not support multiple instances of VLCLibrary. Furthermore, you cannot destroy any | ||
| * instiantiation of VLCLibrary, as previously noted, this is done automatically by the dynamic link loader. | ||
| * Currently, the framework __does not__ support multiple instances of VLCLibrary. | ||
| * Furthermore, you __cannot__ destroy any instance of VLCLibrary; this is done automatically by the dynamic link loader. |
This comment has been minimized.
This comment has been minimized.
fkuehne
Jul 29, 2018
Contributor
I'm not sure if this underling syntax is permitted in doxygen. Can you verify this?
This comment has been minimized.
This comment has been minimized.
mkchoi212
Jul 30, 2018
Contributor
Ah I had no idea this was run through doxygen. And turns out, doxygen only supports __ syntax for markdown.
mkchoi212
added some commits
Jul 20, 2018
mkchoi212
force-pushed the
mkchoi212:lib-test
branch
from
2a1db09
to
383ff95
Jul 30, 2018
This comment has been minimized.
This comment has been minimized.
|
ping |
This comment has been minimized.
This comment has been minimized.
|
merged |
mkchoi212 commentedJul 20, 2018
•
edited
Fixes the bugs
debugLoggingStatuscan not be setdebugLoggingLevelcan exceed the set range of 0-4