Repository navigation
Conversation
955b24e to
c84b345
Compare
| let oldCount = mediaList.count | ||
|
|
||
| // Remove media from list | ||
| let ok = mediaList.removeMedia(at: idx) |
There was a problem hiding this comment.
move the XCTAssertTrue here maybe? :D
c84b345 to
1b8ff8c
Compare
6d77660 to
69b65e9
Compare
|
Commits have been rebased :D Sorry for noticing it just now! |
|
|
||
| for (deleteIdx, count, ok) in tests { | ||
| let removalResult = mediaList.removeMedia(at: deleteIdx) | ||
| XCTAssertEqual(removalResult, ok) |
There was a problem hiding this comment.
I would rename it from ok to removalSuccessful
| (10, 0, false), | ||
| ] | ||
|
|
||
| let source = Video.standards.map{ VLCMedia(path: $0.path) } |
There was a problem hiding this comment.
isn't this fragile? When someone adds a Video to the standards the entire tests will fail, right?
| class VLCMediaListTest: XCTestCase { | ||
|
|
||
| func testRemoveMedia() throws { | ||
| let videos = [Video.test1, Video.test1, Video.test2, Video.test3, Video.test4, Video.test4] |
There was a problem hiding this comment.
I like this approach better than the standards
| ] | ||
|
|
||
| for (targetIdx, expectedState, ok) in tests { | ||
| let removalResult = mediaList.removeMedia(at: targetIdx) |
| (1, [NF, 0,NF,NF,NF, 1], true), | ||
| (8, [NF, 0,NF,NF,NF, 1], false), | ||
| (0, [NF,NF,NF,NF,NF, 0], true), | ||
| (0, [NF,NF,NF,NF,NF,NF], true), |
There was a problem hiding this comment.
quick question when you try again to remove at index 0 after removing it already at index 0 shouldn't the result be false? Do we need the NF in expectedState? I found it a bit confusing to match the index with the correct position because of it
There was a problem hiding this comment.
quick question when you try again to remove at index 0 after removing it already at index 0 shouldn't the result be false?
No, because the previous state contains a media. expectedState is what the list looks like after the removal.
Do we need the NF in expectedState?
I see where you are coming from and yeah it's a bit hard to match the indices. But I think it would be better to be explicit about exactly which media was removed.
e.g. Let say you have something like this
let videos = [Video.test1, Video.test1]
let removalResult = mediaList.removeMedia(at: 0)
let currentState = source.map{ mediaList.index(of: $0) }
XCTAssertEqual(currentState, [0])From XCTAssertEqual(currentState, [0]), you can't tell which of the two Video.test1 was removed.
fc2efed to
f7d8d71
Compare
f7d8d71 to
367ed70
Compare
4 participants
Includes tests for #34
VLCMediaList::removeMediaAtNeeds to be rebased after #34