New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: VLCMediaThumbnailer #37

Merged
merged 1 commit into from Aug 29, 2018

Conversation

Projects
None yet
3 participants
@mkchoi212
Contributor

mkchoi212 commented Aug 3, 2018

Needs to be rebased after #33 is merged

@mkchoi212 mkchoi212 force-pushed the mkchoi212:thumbnail-tests branch from 4a3e74b to 05d1068 Aug 7, 2018

@mkchoi212

This comment has been minimized.

Contributor

mkchoi212 commented Aug 7, 2018

Rebased!

@mkchoi212 mkchoi212 force-pushed the mkchoi212:thumbnail-tests branch from 05d1068 to 21114d6 Aug 27, 2018

@mkchoi212

This comment has been minimized.

Contributor

mkchoi212 commented Aug 27, 2018

rebased again :D

@carolanitz

Really great tests!

for media in tests {
let delegate = MockThumbnailerDelegate()
let thumbnailer = try XCTAssertNotNilAndUnwrap(VLCMediaThumbnailer(media: media, andDelegate: delegate))

This comment has been minimized.

@carolanitz

carolanitz Aug 29, 2018

Member

can we add for the swift function a specifier to remove things like andDelegate so that it would be VLCMediaThumbnailer(media: media, delegate: delegate) instead?

(nil, sharedLibrary)
]
for (library, expected) in tests {

This comment has been minimized.

@carolanitz

carolanitz Aug 29, 2018

Member

nitpick: expectedLibrary

@vlc-mirrorer vlc-mirrorer merged commit 21114d6 into videolan:master Aug 29, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@mkchoi212 mkchoi212 deleted the mkchoi212:thumbnail-tests branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment