Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: VLCMediaThumbnailer #37

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

mkchoi212
Copy link
Contributor

Needs to be rebased after #33 is merged

@mkchoi212
Copy link
Contributor Author

Rebased!

@mkchoi212
Copy link
Contributor Author

rebased again :D

Copy link
Member

@carolanitz carolanitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great tests!


for media in tests {
let delegate = MockThumbnailerDelegate()
let thumbnailer = try XCTAssertNotNilAndUnwrap(VLCMediaThumbnailer(media: media, andDelegate: delegate))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add for the swift function a specifier to remove things like andDelegate so that it would be VLCMediaThumbnailer(media: media, delegate: delegate) instead?

(nil, sharedLibrary)
]

for (library, expected) in tests {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: expectedLibrary

@vlc-mirrorer vlc-mirrorer merged commit 21114d6 into videolan:master Aug 29, 2018
@mkchoi212 mkchoi212 deleted the thumbnail-tests branch August 29, 2018 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants