Foxiy/class #9
Merged
Foxiy/class #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added more comments to functions. Signed-off-by: Ondrej Jariabka <o.jariabka@gmail.com>
* Moved detection of a board to class Signed-off-by: Ondrej Jariabka <o.jariabka@gmail.com>
| def get_board(self, image): | ||
| """ | ||
| Makes a copy of input image, applies a median blur to cartoon-ify the | ||
| image. It gets rid of noise and not wanted colors. Calls function which will |
There was a problem hiding this comment.
I undestand this is probably just a tab but visually this is already further than 80 characters. Can we do something about it?
* Added function that takes as parameter normal image and returns conture of that image. Signed-off-by: Ondrej Jariabka <o.jariabka@gmail.com>
| self.H, self.S, self.V]))) | ||
|
|
||
|
|
||
| def timeit(func): |
There was a problem hiding this comment.
I believe this can be put out of the classes scope.
Closed
Signed-off-by: Ondrej Jariabka <o.jariabka@gmail.com>
| 46 22 2 83 181 137 |
There was a problem hiding this comment.
As I've mentioned earlier 36 worked better for me.
|
@FOXIY looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.