New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviceDetectionListener useless #113

Open
TheQmaks opened this Issue Dec 18, 2018 · 4 comments

Comments

2 participants
@TheQmaks
Copy link

TheQmaks commented Dec 18, 2018

My steps:

  1. Run java program with listener
  2. adb connect ip:port
  3. We get nothing

If i create new thread with while loop and delay printing connection.getDevices().size() - it updated and print me newer devices list. But to listener it doesn't go.

@vidstige

This comment has been minimized.

Copy link
Owner

vidstige commented Dec 25, 2018

I never liked the Listener anyway. Does not feel like core jadb stuff. I would rather remove it than fix it.

@TheQmaks

This comment has been minimized.

Copy link

TheQmaks commented Dec 25, 2018

I just used getDevices method in loop with checking already added devices by serial. So you can remove it if you like.

@vidstige

This comment has been minimized.

Copy link
Owner

vidstige commented Dec 31, 2018

Waiting a while to see if someone wants to help out with this, before I jump onto it.

@TheQmaks

This comment has been minimized.

Copy link

TheQmaks commented Jan 2, 2019

I not see listeners in adb server documentation. So i think it better solution, for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment